Comment 1 Gleb Popov 2024-01-16 20:06:41 UTC

Do you use this software yourself or know someone who uses it?

(In reply to Gleb Popov from comment #1)
Yes, and according to all the downloads in my web logs,
others do too. :-)

Comment 3 Rene Ladan 2024-01-16 22:37:15 UTC

(In reply to Chris Hutchinson from comment #2)
And none can move on to say, rxvt-unicode?

(In reply to Rene Ladan from comment #3)
Can't say. I'm not running a forum for it. But based on
the user-agent field (fetch libfetch/2.0), there were
97 installs since beginning of December 2023.

Comment 5 Gleb Popov 2024-01-17 11:37:14 UTC

(In reply to Chris Hutchinson from comment #4)
Can you please check IP addresses of connections with the "fetch" agent and share them here? All of them might be just IPs of FreeBSD building machines.

Created attachment 247731 [details]
XVT installs IP addresses from 2023-12 - 2024-01-17

I preformed a grep -F xvt-3.0.1.tar.xz against my web log
with a range of 2023-12-01 - 2024-01-17. I then filtered that output
against grep -F fetch. Finally capturing the IP/host entries with an
awk '{ print $1; }', Please find the results attached.

There are indeed duplicates and freebsd related hosts. But I fail
to undersand why all the bother. This is clearly a used port, for
which I perform the bulk of the maintenance.

Anyway. There you have it. :-)

--Chris

OH! I should also mention that there are some 6 days missing where I
neglected to renew the domain. So the number would otherwise be higher.

Comment 7 Gleb Popov 2024-01-17 19:56:32 UTC

(In reply to Chris Hutchinson from comment #6)
> But I fail to undersand why all the bother.

I already explained it on the mailing list. Each port adds a maintenance cost on Ports project as a whole, so we as a project are interested in not keeping useless things, not doing useless work. I highly doubt that ports such as this one have any real value and users, which is why I'm trying to become 100% sure we want it in the tree.

Comment 8 Koichiro Iwao 2024-01-26 02:52:59 UTC

(In reply to Gleb Popov from comment #7)

I think that it is fine to keep ports in the tree if the port has a maintainer still willing to maintain them and the maintainer pays some cost to keep the ports working effectively.

For example, I quit maintaining net/tightvnc and marked it as deprecated because of multiple vulnerabilities, the last release was in 2009 and there is a replacement such as net/tigervnc-{viewer,server} in ports tree. After the expiration date, it was removed from ports tree but resurrected by a new maintainer.  New maintainer dinoex@ created patches to fix vulnerabilities.

https://cgit.freebsd.org/ports/commit/net/tightvnc/Makefile?id=e2ce35496ec36b520b7a25aeea1f4111449dcf12
https://cgit.freebsd.org/ports/commit/net/tightvnc/Makefile?id=f374ddf115d4f8d15c5f255c0a0be756f986bd66


Personally, I agree that x11/xvt is outdated, old-school software not widely used but I would like to respect the maintainer's decision to keep maintain this time. The trigger marking this as deprecated is the absence of a maintainer but it was an accident (domain unavailability).

Created attachment 248650 [details]
updates x11/xvt to version 3.0.2

New patch for x11/xvt which incorporates previous changes
and updates x11/xvt to version 3.0.2.

I have moved xvt to a public VCS to encourage public review
and participation. xvt, however old, is still a valuable terminal
emulator that I would consider a powerful alternative to xterm. It
has near feature parity, yet weighs in at 175th the size of Xterm!
Xterm weighs in at: 829024 bytes. Xvt weighs in at: 4736 bytes.
It's a great candidate for inclusion in projects like nanobsd. It is
also a great candidate for forensic software, where running in RAM
imposes restrictions that don't normally exist. It would also be a
good choice for other resource restricted environments. Or just as
a faster smaller alternative to Xterm.

Frankly; the decision to nuke this port feels more personal than
pragmatic. :(

Changes introduced in this patch:
Makefile (PORTVERSION, MAINTAINER, MASTER_SITES, WWW)
distinfo
removal of unnecessary clutter in files/
patch-src__command.c
patch-src__init.c
patch-src__screen.c
patch-src__xvt.h
patch-src_logging.c
and the addition of
README.xvt

Tested against releng/(13,14) && current

@meta
Thank you, Koichiro Iwao, for your view and support in this matter.

--Chris

Created attachment 248651 [details]
patch to update x11/xvt to version 3.0.3

Forgot to push doc changes before tag. This version incorporates
those doc changes.

CHANGES
Makefile (PORTVERSION)
distinfo

That's it.

--Chris

Comment 11 Gleb Popov 2024-02-21 18:40:11 UTC

Your post-extract target can be replaced with 

WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION}

I also suspect that running portlint -AC will give you some warnings.

Created attachment 248666 [details]
patch for x11/xvt version 4

> WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION}
Good catch. But I think you meant:
WRKSRC= ${WRKDIR}/${PORTNAME}
which works as expected. Thanks. :)
As to portlint(1). I get 2 erroneous warns and a couple
more regarding makepatch. But makepatch generates no alternatives.
But I did rename 2 of the 3 patches to conform to current naming
conventions.

Thanks again!

--Chris

Created attachment 248674 [details]
patch for x11/xvt (version 5) final

OK I was able to coerce make makepatch to generate
patches that portlint(1) likes.
So this is an update that includes everything else and
now includes patches that portlint(1) likes.

I think I'm done here. :)

Thanks.

--Chris

Comment 14 Gleb Popov 2024-02-22 05:50:35 UTC

One last nit-pick and this will be ready to get in.

I see that you first have the unconditional "--disable-languages" item in CONFIGURE_ARGS which is then gets overriden with "--enable-languages" if the corresponding option is on.

This is exactly when https://docs.freebsd.org/en/books/porters-handbook/makefiles/#options-configure_enable comes to help. Unless the configure script does something silly, you should be able to use OPT_CONFIGURE_ENABLE instead of OPT_CONFIGURE_ON to get rid of most of CONFIGURE_ARGS items.

Created attachment 248682 [details]
patch for x11/xvt (version 6)

It's for multichar glyph support
(--enable-languages      enable multichar glyph language support]).
Which has no value *unless* any of the language options
are chosen. I left --disable-languages in, in the event the default
GB encoding option was un-selected. But upon further investigation
it seems unnecessary. So I scratched your itch and removed
--enable-languages. :)
Due to some fat-fingering on my part attempting to push some changes
I've had to bump the tag to 3.0.6.
I've tested everything in the attached patch against releng/(13,14) and current.

Thanks!

--Chris

P.S. I've got some changes in the pipeline that I'm
going to be pushing that add a couple of additional
options. I won't be able to get them in for a couple
of weeks. I'll convert the options to OPT_CONFIGURE_ENABLE
at that time.

Thanks again for all your time and efforts here, Gleb. :)

--Chris

Created attachment 248683 [details]
patch for x11/xvt (version 7) final

OK. It was too trivial not to include now. This
patch should scratch all your itches. ;)
It includes the CONFIGURE_ENABLE change you requested.

I'm done here. :)

--Chris

Comment 18 commit-hook 2024-02-23 09:01:20 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c446a9e1d89e4211558b0004c910ff3cc9187fec

commit c446a9e1d89e4211558b0004c910ff3cc9187fec
Author:     Chris Hutchinson <portmaster@bsdforge.com>
AuthorDate: 2024-02-23 08:51:51 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2024-02-23 08:59:26 +0000

    x11/xvt: Update to 3.0.6

    PR:             276387

 x11/xvt/Makefile                                   | 82 ++++++++++++----------
 x11/xvt/distinfo                                   |  5 +-
 x11/xvt/files/patch-Makefile.in                    | 30 +++-----
 ...onf__config.h.in => patch-autoconf_config.h.in} |  4 +-
 ...atch-doc__Makefile.in => patch-doc_Makefile.in} |  6 +-
 x11/xvt/files/patch-src__command.c (gone)          | 11 ---
 x11/xvt/files/patch-src__init.c (gone)             | 22 ------
 x11/xvt/files/patch-src__screen.c (gone)           | 62 ----------------
 x11/xvt/files/patch-src__xvt.h (gone)              | 11 ---
 x11/xvt/files/patch-src_logging.c (gone)           | 50 -------------
 x11/xvt/pkg-plist                                  |  2 +-
 11 files changed, 64 insertions(+), 221 deletions(-)

Comment 19 Gleb Popov 2024-02-23 09:02:04 UTC

Pushed in, thank you for your commitment to addressing raised comments.