Bug 276548 - misc/py-openai: update runtime dependency on py-pydantic to py-pydantic2
Summary: misc/py-openai: update runtime dependency on py-pydantic to py-pydantic2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Hiroki Tagato
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-23 08:40 UTC by Hiroki Tagato
Modified: 2024-02-03 06:02 UTC (History)
1 user (show)

See Also:
yuri: maintainer-feedback+

Attachments
Patch (1.00 KB, patch)
2024-01-23 08:40 UTC, Hiroki Tagato 		tagattie: maintainer-approval? (yuri)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hiroki Tagato freebsd_committer freebsd_triage 2024-01-23 08:40:48 UTC 
Created attachment 247872 [details]
Patch

misc/py-openai: update runtime dependency on py-pydantic to py-pydantic2

Update the dependency on py-pydantic to py-pydantic2 which is more recent version satisfying the version requirement specified in pyproject.toml.

While here, bump port revision for dependency change.
Comment 1 Hiroki Tagato freebsd_committer freebsd_triage 2024-02-03 03:28:10 UTC 
This is a gentle reminder.

Are you comfortable with the proposed change?
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2024-02-03 03:46:26 UTC 
Hi Hiroki,


There should be only one pydantic in the ports tree, not two.
Currently there are a lot of conflicts due to this, because both of them use the same namespace.

Why would you want to change to pydantic2? Is anything malfunctioning?
This change would cause conflicts for someone.

The correct dependency is just pydantic, and it should be at version 2, but it is at version 1 due to conflicts.

I would agree if there is a compelling reason to update to pydantic2.


Thanks,
Yuri
Comment 3 Hiroki Tagato freebsd_committer freebsd_triage 2024-02-03 04:25:30 UTC 
Hi Yuri,

Thanks for your reply.

I'm the maintainer of misc/py-shell-gpt. Its dependency graph is partly as follows:

misc/py-shell-gpt -> misc/py-instructor -> devel/py-pydantic2
                     (pyproject.toml contains pydantic = "^2.0.2")
                  -> misc/py-openai -> devel/py-pydantic
                     (pyproject.toml contains "pydantic>=1.9.0, <3")

Updating the dependency of misc/py-openai to pydantic2 satisfies both requirements at the same time.
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2024-02-03 04:38:14 UTC 
Hi Hiroki,

Patch approved.

Please commit it.


Thanks,
Yuri
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-02-03 06:02:05 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f4ab72f99290a7069080a9a0abd23442bac3aee4

commit f4ab72f99290a7069080a9a0abd23442bac3aee4
Author:     Hiroki Tagato <tagattie@FreeBSD.org>
AuthorDate: 2024-02-03 05:57:38 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2024-02-03 06:01:37 +0000

    misc/py-openai: update runtime dependency on py-pydantic to py-pydantic2

    misc/py-shell-gpt (one of the dependent ports on py-openai) has the
    following dependency graph:

    misc/py-shell-gpt -> misc/py-instructor -> devel/py-pydantic2
                         (pyproject.toml contains pydantic = "^2.0.2")
                      -> misc/py-openai -> devel/py-pydantic
                         (pyproject.toml contains "pydantic>=1.9.0, <3")

    Updating the dependency of py-openai to py-pydantic2 satisfies both
    requirements at the same time.

    PR:             276548
    Approved by:    yuri (maintainer)

 misc/py-openai/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 6 Hiroki Tagato freebsd_committer freebsd_triage 2024-02-03 06:02:50 UTC 
Committed, thanks!