Bug 276609 - x11/sfwbar: add python as runtime dependency
Summary: x11/sfwbar: add python as runtime dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Zsolt Udvari
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-25 15:43 UTC by Tino Engel
Modified: 2024-10-29 11:51 UTC (History)
1 user (show)

See Also:

Attachments
[PATCH] x11/sfwbar: added python as runtime dependency (720 bytes, patch)
2024-01-25 15:43 UTC, Tino Engel 		tino.engel: maintainer-approval+
Details | Diff
add python, pet portfmt (1.41 KB, patch)
2024-10-29 05:53 UTC, Zsolt Udvari 		uzsolt: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tino Engel 2024-01-25 15:43:01 UTC 
Created attachment 247949 [details]
[PATCH] x11/sfwbar: added python as runtime dependency

Since some modules of sfwbar required python (e.g. the main application menu), python has been added as runtime dependency.
Comment 1 Zsolt Udvari freebsd_committer freebsd_triage 2024-06-21 18:58:05 UTC 
Could you please check 'portfmt -D Makefile' (part of ports-mgmt/portfmt)? And please bump PORTREVISION.
Comment 2 Zsolt Udvari freebsd_committer freebsd_triage 2024-08-11 19:42:45 UTC 
Friendly ping.
Comment 3 Tino Engel 2024-08-11 19:45:28 UTC 
In the meantime a new version is out, I will fix this during updating.
Please leave this ticket open as reminder.
Comment 4 Zsolt Udvari freebsd_committer freebsd_triage 2024-08-23 18:58:20 UTC 
(In reply to Tino Engel from comment #3)
Okay.
Comment 5 Zsolt Udvari freebsd_committer freebsd_triage 2024-10-28 06:45:54 UTC 
Friendly ping.
Comment 6 Tino Engel 2024-10-28 13:09:49 UTC 
Thank you for the ping.
At the moment unfortunately I have no time to care about this.
As soon as I find some time and motivation for the port, I will port the latest release and add python as dependency during that process.
Since I am submitter of this PR, for me it also is fine to close it.
Comment 7 Zsolt Udvari freebsd_committer freebsd_triage 2024-10-29 05:53:38 UTC 
Created attachment 254607 [details]
add python, pet portfmt

If you approve it I'll commit.
Comment 8 Tino Engel 2024-10-29 09:24:42 UTC 
Comment on attachment 254607 [details]
add python, pet portfmt

Thanks a lot!
I hope I have approved correctly.
Comment 9 Tino Engel 2024-10-29 09:31:26 UTC 
To me it seems, it does not save setting the "+" on attachments maintainer approval.
Anyhow I have looked at the attachment and it looks fine to me.
So I am willing to approve.
Comment 10 commit-hook freebsd_committer freebsd_triage 2024-10-29 11:50:49 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9355ee51b8b74e4407671692f1f3607bf4795621

commit 9355ee51b8b74e4407671692f1f3607bf4795621
Author:     Tino Engel <tino.engel@mail.de>
AuthorDate: 2024-10-29 11:49:04 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2024-10-29 11:49:52 +0000

    x11/sfwbar: Add python as runtime dependency

    Pet portfmt.

    PR:             276609
    Approved by:    submitter is maintainer

 x11/sfwbar/Makefile | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
Comment 11 Zsolt Udvari freebsd_committer freebsd_triage 2024-10-29 11:51:31 UTC 
Committed, thanks!