This updates the audio/cutmp3 package to the latest version (3.0.3) and adds me as the maintainer.
Created attachment 248137 [details] patch to update to 3.0.3
*** Bug 276779 has been marked as a duplicate of this bug. ***
Please update patch to follow https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github (first example including ordering) USES= tar:bzip2 This is incorrect if you're using USE_GITHUB (see section in Porters Handbook) Can we unbundle (lib)linenoise? https://docs.freebsd.org/en/books/porters-handbook/book/#bundled-libs-practices Do not override optimization https://docs.freebsd.org/en/books/porters-handbook/book/#dads-cflags Manpage should be installed into share/man Looks like USES= ncurses should be added too? Out of curiosity, does this provide any new functionality that ffmpeg dont?
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field. Q/A: PORTREVISION should be removed --> No need to update a new patch for this. Thanks!
Thank you both for your review. This is my first time contributing and I made some mistakes, I'll try and do better. I'll work on a new patch which fixes the problems you both pointed out. Daniel: I'd be happy to create another port for linenoise if you think that's needed. The previous maintainers of this port did not support it, which is why I did not think to do so. I haven not tried that feature personally, but I can try it out if it's important. Thank you.
If linenoise is optional that fine otherwise please try to use the port instead.
Fernando: I don't see a field named URL described in the handbook or bsd.port.mk, do you perhaps mean another field?
Created attachment 248185 [details] updates based on review feedback
I've added a patch based on the feedback, which I think addresses most of it: - Got rid of bzip2 - Uses DISTVERSION instead of PORTVERSION - Reorders the Makefile. portlint comes out clean now - Manpage is in the share/man folder now - CFLAGS is additive - PORTREVISION is removed ---- About ncurses, it's not actually used in the library. I'm not sure why the makefile mentions it, perhaps an old feature? You can see from the makefile the library is never used.
(In reply to Matthew Phillips from comment #7) The URL field in this PR, right between "Assignee" and "Keywords" :-)
Hi Mathew, Can you provide all the changes into one single patch that applies to the ports tree?
Created attachment 248187 [details] Full patch for 3.0.3 upgrade to cutmp3 This is the full patch for cutmp3 3.0.3 with changes requested in review feedback.
Still applies -O2 unconditionally :/
Created attachment 248188 [details] cutmp3 3.0.3 Full patch, this time removing 02
Committed, Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=9250636afac175988c15f82bb09f976ebd17c84b commit 9250636afac175988c15f82bb09f976ebd17c84b Author: Matthew Phillips <matthew@matthewphillips.info> AuthorDate: 2024-02-07 07:47:49 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2024-02-08 16:57:39 +0000 audio/cutmp3: update to 3.0.3 ChangeLog: https://github.com/tarjanm-movidius/cutmp3/releases/tag/v3.0.3 Submitter becomes maintainer for the first time. PR: 276780 Reported by: matthew@matthewphillips.info Reviewed by: diizzy@ audio/cutmp3/Makefile | 17 ++++++------ audio/cutmp3/distinfo | 5 ++-- audio/cutmp3/files/patch-Makefile | 54 +++++++++++++++++++-------------------- 3 files changed, 38 insertions(+), 38 deletions(-)