Created attachment 248158 [details] Patch to sysutils/testdisk/Makefile, fixing version of dependency on sysutils/progsreiserfs With PROGSREISERFS set, the testdisk build fails with ===> testdisk-7.2 depends on shared library: libreiserfs-0.3.so - not found The problem appears to be that the testdisk Makefile depends on libreiserfs-0.3.so:sysutils/progsreiserfs but sysutils/progsreiserfs installs libreiserfs.so, libreiserfs-0.3.so.0, and libreiserfs-0.3.so.0.0.1. The attached patch modifies the testdisk Makefile to depend on libreiserfs-0.3.so.0.
Thanks you for spoting this. I remember testing all options and I did try to pet Q/A: ######## ====> Running Q/A tests (stage-qa) Error: /usr/local/bin/testdisk is linked to /usr/local/lib/libreiserfs-0.3.so.0 from sysutils/progsreiserfs but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libreiserfs-0.3.so:sysutils/progsreiserfs ######## Using this tip (LIB_DEPENDS+=libreiserfs-0.3.so:..) gives build error as you spoted. Q/A ldd shows: 0x0000000000000001 NEEDED Shared library: [libreiserfs-0.3.so.0] and if it is set as lib depends on libreiserfs-0.3.so.0: ====> Running Q/A tests (stage-qa) Warning: you might not need LIB_DEPENDS on libreiserfs-0.3.so.0 Something is wrong here, but fixing it anyway as it makes sense to be as your patch instructs.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=907465b3032c41ddd7d4752121b0cca8305b3aef commit 907465b3032c41ddd7d4752121b0cca8305b3aef Author: Nicholas Taylor <nicholas.e.taylor@gmail.com> AuthorDate: 2024-02-03 16:38:17 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2024-02-03 16:40:42 +0000 sysutils/testdisk: Fix build with PROGSREISERFS option Fix typo on lib depends for PROGSREISERFS option. PR: 276803 sysutils/testdisk/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Committed thanks!