Bug 276846 - databases/pg_vector: Rename to match upstream and fix license
Summary: databases/pg_vector: Rename to match upstream and fix license
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Torsten Zuehlsdorff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-05 21:20 UTC by Andrew Kane
Modified: 2024-02-06 20:42 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (tz)

Attachments
Patch (2.50 KB, text/plain)
2024-02-05 21:20 UTC, Andrew Kane 		no flags Details
Patch v2 (3.19 KB, patch)
2024-02-06 00:00 UTC, Andrew Kane 		no flags Details | Diff
Patch v3 (3.19 KB, patch)
2024-02-06 20:07 UTC, Andrew Kane 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Kane 2024-02-05 21:20:41 UTC 
Created attachment 248209 [details]
Patch

Hi, thanks for adding a port for pgvector! This patch updates the name to be consistent with upstream and fixes the license identifier.
Comment 1 Andrew Kane 2024-02-05 21:56:54 UTC 
Also, I think the build failures on some platforms can be fixed by having it use:

make OPTFLAGS=""
Comment 2 Andrew Kane 2024-02-06 00:00:10 UTC 
Created attachment 248212 [details]
Patch v2
Comment 3 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2024-02-06 19:53:47 UTC 
Aloha Andrew,

thank you for fixing this! :)

I tried to apply the patch, but "git apply" failed at the MOVED. Do i need to apply it in another way?

Best,
Torsten
Comment 4 Andrew Kane 2024-02-06 20:07:05 UTC 
Created attachment 248221 [details]
Patch v3

Thanks Torsten. It looks like someone moved another port, causing a conflict. Just pushed a new patch.
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-02-06 20:33:17 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=65494cab7b3d95c81e99957fc49e6f7e8e9a9b4d

commit 65494cab7b3d95c81e99957fc49e6f7e8e9a9b4d
Author:     Torsten Zuehlsdorff <tz@FreeBSD.org>
AuthorDate: 2024-02-06 20:31:13 +0000
Commit:     Torsten Zuehlsdorff <tz@FreeBSD.org>
CommitDate: 2024-02-06 20:31:13 +0000

    databases/pg_vector: Rename to match upstream and fix license

      Also split DISTVERSION into PORTVERSION and DISTVERSIONPREFIX

    PR:             276846
    Reported by:    Andrew Kane <andrew@ankane.org>

 MOVED                                       | 1 +
 databases/Makefile                          | 2 +-
 databases/{pg_vector => pgvector}/Makefile  | 8 +++++---
 databases/{pg_vector => pgvector}/distinfo  | 0
 databases/{pg_vector => pgvector}/pkg-descr | 0
 databases/{pg_vector => pgvector}/pkg-plist | 0
 6 files changed, 7 insertions(+), 4 deletions(-)
Comment 6 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2024-02-06 20:34:09 UTC 
Thank you Andrew :)

I fixed a small Typo in the MOVED file (databaseS instead of database) and committed your patch.
Comment 7 Andrew Kane 2024-02-06 20:42:20 UTC 
Awesome, thank you! (and great catch)