Bug 276854 - devel/ccache4: Update to 4.10.2
Summary: devel/ccache4: Update to 4.10.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL: https://ccache.dev/releasenotes.html#...
Keywords:
: 283910 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-02-06 09:46 UTC by Oleg Sidorkin
Modified: 2025-01-29 16:34 UTC (History)
4 users (show)

See Also:
vvd: maintainer-feedback-


Attachments
Patch to update devel/ccache4 from 4.9 to 4.9.1 (via git am) (1.13 KB, patch)
2024-02-06 09:46 UTC, Oleg Sidorkin
no flags Details | Diff
Patch to update devel/ccache4 from 4.9 to 4.9.1 (via git am) v. 2 (1.51 KB, patch)
2024-03-08 08:12 UTC, Oleg Sidorkin
no flags Details | Diff
Patch to update devel/ccache4 from 4.9 to 4.9.1 (via git am) v. 3 (1.50 KB, patch)
2024-04-01 13:41 UTC, Oleg Sidorkin
no flags Details | Diff
Patch to update devel/ccache4 from 4.9 to 4.10 (via git am) (2.11 KB, patch)
2024-05-30 13:17 UTC, Oleg Sidorkin
no flags Details | Diff
ccache4-4.10.diff (4.06 KB, patch)
2024-05-30 20:41 UTC, Denis Shaposhnikov
no flags Details | Diff
Patch to update devel/ccache4 from 4.9 to 4.10.1 (via git am) (2.29 KB, patch)
2024-07-01 09:03 UTC, Oleg Sidorkin
no flags Details | Diff
Patch to update devel/ccache4 from 4.9 to 4.10.1 (via git am) v2 (2.29 KB, patch)
2024-07-01 11:58 UTC, Oleg Sidorkin
no flags Details | Diff
Patch to update devel/ccache4 from 4.9 to 4.10.2 (via git am) (2.29 KB, patch)
2024-07-22 16:25 UTC, Oleg Sidorkin
osidorkin: maintainer-approval?
Details | Diff
v1 (3.59 KB, patch)
2025-01-29 11:42 UTC, Vladimir Druzenko
no flags Details | Diff
v2 (3.81 KB, patch)
2025-01-29 12:45 UTC, Vladimir Druzenko
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Sidorkin 2024-02-06 09:46:24 UTC
Created attachment 248218 [details]
Patch to update devel/ccache4 from 4.9 to 4.9.1 (via git am)

Hi. New version was released recently with a few minor bugfixes for several corner cases.

While here, pet portlint

Poudriere tests passed. src built fine
Comment 1 Oleg Sidorkin 2024-02-20 14:21:22 UTC
Maintainer timeout?
Comment 2 Oleg Sidorkin 2024-03-08 08:12:27 UTC
Created attachment 249018 [details]
Patch to update devel/ccache4 from 4.9 to 4.9.1 (via git am) v. 2

While here, add llvm18 to the list of compilers
Comment 3 Oleg Sidorkin 2024-04-01 13:41:17 UTC
Created attachment 249635 [details]
Patch to update devel/ccache4 from 4.9 to 4.9.1 (via git am) v. 3

Chase llvm10 removal
Comment 4 Oleg Sidorkin 2024-05-30 13:17:47 UTC
Created attachment 251087 [details]
Patch to update devel/ccache4 from 4.9 to 4.10 (via git am)

4.10 has been released.
libfmt and xxHash are external now.

poudriere checks passed.
Comment 5 Denis Shaposhnikov 2024-05-30 15:50:24 UTC
(In reply to Oleg Sidorkin from comment #4)
Looks like it breaks build with STATIC option:

CMake Error at cmake/FindFmt.cmake:33 (message):
  Could not find Fmt>=8.0.0

because it's looking for libfmt.a and devel/libfmt has libfmt.so.
Comment 6 Denis Shaposhnikov 2024-05-30 20:41:18 UTC
Created attachment 251102 [details]
ccache4-4.10.diff

I fixed building with STATIC option and attached the patch. Testing by poudriere with and without STATIC option.
Comment 7 Oleg Sidorkin 2024-05-31 10:58:53 UTC
(In reply to Denis Shaposhnikov from comment #6)
Thanks.
That's much easier than teaching libfmt to build both static and shared versions.
Comment 8 Vladyslav V. Prodan 2024-06-16 17:13:03 UTC
Up.
Comment 9 Oleg Sidorkin 2024-07-01 09:03:59 UTC
Created attachment 251808 [details]
Patch to update devel/ccache4 from 4.9 to 4.10.1 (via git am)

4.10.1 was released. It has libfmt bundled again. Switch port to it, so now both static and non-static cases are handled correclty.

Also update list of compilers we have in ports.

Thanks.
Comment 10 Oleg Sidorkin 2024-07-01 11:58:41 UTC
Created attachment 251812 [details]
Patch to update devel/ccache4 from 4.9 to 4.10.1 (via git am) v2

Truncate removed GCCs.

Poudriere checks passed.
Comment 11 Oleg Sidorkin 2024-07-22 16:25:32 UTC
Created attachment 252228 [details]
Patch to update devel/ccache4 from 4.9 to 4.10.2 (via git am)

4.10.2 was released. Update patch to it.
Comment 12 Vladyslav V. Prodan 2024-08-23 23:15:24 UTC
Up.
Comment 13 Vladimir Druzenko freebsd_committer freebsd_triage 2025-01-29 09:57:50 UTC
*** Bug 283910 has been marked as a duplicate of this bug. ***
Comment 14 Vladimir Druzenko freebsd_committer freebsd_triage 2025-01-29 09:59:26 UTC
Maintainer timeout 1 year.
Comment 15 Vladimir Druzenko freebsd_committer freebsd_triage 2025-01-29 11:42:57 UTC
Created attachment 257084 [details]
v1

Based on patches from Oleg Sidorkin and Älven.

Improve port:
- Update required compiler version from 11 to 17.
- Update CONFLICTS_INSTALL.
- Update GNU_COMPILERS and CLANG_COMPILERS.
- Update LIB_DEPENDS.
- Update dependencies in STATIC and TEST options.
- Fix warnings from portclippy - sort options.

Please test it in runtime.
Comment 16 Oleg Sidorkin 2025-01-29 12:15:36 UTC
(In reply to Vladimir Druzenko from comment #15)

Shouldn't libfmt dependency be added only for non-static build?
Comment 17 Vladimir Druzenko freebsd_committer freebsd_triage 2025-01-29 12:19:17 UTC
(In reply to Oleg Sidorkin from comment #16)
Yes. But also archivers/zstd and devel/xxhash should be BUILD_DEPENDS with STATIC build instead of LIB_DEPENDS.
Comment 18 Oleg Sidorkin 2025-01-29 12:20:19 UTC
(In reply to Vladimir Druzenko from comment #17)

xxhash provides static library file, so it should be ok to use port
Comment 19 Vladimir Druzenko freebsd_committer freebsd_triage 2025-01-29 12:24:59 UTC
Testing this change:
-LIB_DEPENDS+=   libzstd.so:archivers/zstd \
-                libfmt.so:devel/libfmt \
-                libxxhash.so:devel/xxhash

+STATIC_BUILD_DEPENDS=   ${LOCALBASE}/lib/libzstd.a:archivers/zstd \
+                        ${LOCALBASE}/lib/libxxhash.a:devel/xxhash
+STATIC_LIB_DEPENDS_OFF= libzstd.so:archivers/zstd \
+                        libfmt.so:devel/libfmt \
+                        libxxhash.so:devel/xxhash
Comment 20 Oleg Sidorkin 2025-01-29 12:35:33 UTC
(In reply to Vladimir Druzenko from comment #19)

src builds with both static and dynamic version
Comment 21 Vladimir Druzenko freebsd_committer freebsd_triage 2025-01-29 12:45:08 UTC
Created attachment 257087 [details]
v2

STATIC build don't use dynamic libraries - check poudriere log.
Comment 22 Oleg Sidorkin 2025-01-29 15:38:19 UTC
(In reply to Vladimir Druzenko from comment #21)
looks good
Comment 23 commit-hook freebsd_committer freebsd_triage 2025-01-29 16:33:08 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9f3e54599328a5ca357f46863a17ccb669fd03cf

commit 9f3e54599328a5ca357f46863a17ccb669fd03cf
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2025-01-29 16:18:49 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-01-29 16:32:04 +0000

    devel/ccache4: Update 4.9 → 4.10.2

    Based on patches from Oleg Sidorkin and Älven.

    Improve port:
    - update required compiler version from 11 to 17;
    - update CONFLICTS_INSTALL;
    - update GNU_COMPILERS and CLANG_COMPILERS;
    - update dependencies;
    - improve STATIC and TEST options;
    - fix warnings from portclippy - sort options and etc.

    Changelogs:
    https://ccache.dev/releasenotes.html#_ccache_4_10_2

    PR:             276854 283910
    Approved by:    bdrewery (maintainer, timeout 1 year)
    Tested by:      Oleg Sidorkin (osidorkin@gmail.com), Älven (alster@vinterdalen.se)

 devel/ccache4/Makefile | 59 ++++++++++++++++++++++++++++----------------------
 devel/ccache4/distinfo |  6 ++---
 2 files changed, 36 insertions(+), 29 deletions(-)
Comment 24 Vladimir Druzenko freebsd_committer freebsd_triage 2025-01-29 16:34:23 UTC
Thanks 2 all!