Bug 276988 - net/samba419: conflicts with talloc-2.3.4_1
Summary: net/samba419: conflicts with talloc-2.3.4_1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mikael Urankar
URL:
Keywords:
Depends on: unbundled_samba419_by_default
Blocks:
  Show dependency treegraph
 
Reported: 2024-02-11 17:12 UTC by Denis Shaposhnikov
Modified: 2024-08-01 14:59 UTC (History)
9 users (show)

See Also:
bugzilla: maintainer-feedback? (mikael)


Attachments
fix conflict with talloc (1.69 KB, patch)
2024-02-11 19:19 UTC, Denis Shaposhnikov
no flags Details | Diff
fix conflict with talloc (updated for samba 4.19.5) (1.69 KB, patch)
2024-02-20 18:56 UTC, Denis Shaposhnikov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Shaposhnikov 2024-02-11 17:12:10 UTC
Hi,

I'm trying to install new net/samba419 and found it conflicts with existing ports:

Checking integrity... done (2 conflicting)
  - samba419-4.19.4 conflicts with talloc-2.3.4_1 on /usr/local/share/man/man3/talloc.3.gz

mail/notmuch depends on talloc-2.3.4_1 so it looks like I can't have installed samba419 and notmach together.
Comment 1 Denis Shaposhnikov 2024-02-11 19:19:22 UTC
Created attachment 248369 [details]
fix conflict with talloc

This patch moves talloc.3 into samba-talloc.3 and fixes conflict with ports talloc.
Comment 2 Dean E. Weimer 2024-02-12 19:51:00 UTC
I get that this is a known conflict and even documented. Is this patch to fix it being worked on? I saw the announcement and was looking forward to getting my Samba AD Domain upgraded to 2016 function level supported on 4.19. But I also use FreeRadius3 to provide radius authentication, which of course requires talloc. Can't imagine I am only one using Samba for AD with FreeRadius.
Comment 3 Denis Shaposhnikov 2024-02-12 20:14:38 UTC
(In reply to Dean E. Weimer from comment #2)
It conflicts with one file only, talloc.3. This patch renames samba's talloc.3 to samba-talloc.3 and resolves that conflict.
Comment 4 Dean E. Weimer 2024-02-12 20:24:37 UTC
(In reply to Denis Shaposhnikov from comment #3)

Yes, I just was checking to see if this patch was planning to be applied to the port and not if the change was to just flag the port as conflicting.
Comment 5 Nikita Druba 2024-02-13 17:00:56 UTC
(In reply to Denis Shaposhnikov from comment #1)
Hi! I was applied you patch, but now, when I try to install devel/talloc, I have:

pkg-static: talloc-2.3.4_1 conflicts with samba419-4.19.4_1 (installs files into the same place).  Problematic file: /usr/local/lib/python3.9/site-packages/talloc.cpython-39.so
Comment 6 Denis Shaposhnikov 2024-02-13 18:34:30 UTC
(In reply to Nikita Druba from comment #5)
I'm building net/samba419 with

OPTIONS_UNSET= PYTHON3

so I don't have this conflict.
Comment 7 Nikita Druba 2024-02-13 20:27:38 UTC
(In reply to Denis Shaposhnikov from comment #6)
But AD_DC implies PYTHON3... 
I'm working to separate radius and DC to different jails, but right now its a problem.
Comment 8 Mikael Urankar freebsd_committer freebsd_triage 2024-02-14 08:00:33 UTC
(In reply to Nikita Druba from comment #7)
FWIW you can build devel/talloc without PYTHON
Comment 9 Nikita Druba 2024-02-14 08:58:16 UTC
(In reply to Mikael Urankar from comment #8)
Seems like a solution. Thanx, I didn't pay attention this talloc build option.
Comment 10 Dean E. Weimer 2024-02-14 12:28:07 UTC
(In reply to Nikita Druba from comment #9)
I tried unsettling python option on talloc, poudriere still fails install of talloc reporting conflict.
Comment 11 Nikita Druba 2024-02-14 13:00:45 UTC
(In reply to Dean E. Weimer from comment #10)
Patch applied? 
For me with manually patching, build and reinstall all installed fine.
Comment 12 Denis Shaposhnikov 2024-02-20 18:56:55 UTC
Created attachment 248648 [details]
fix conflict with talloc (updated for samba 4.19.5)
Comment 13 Andrej Ebert 2024-02-28 08:38:40 UTC
Any chance this can be commited? Also, with this patch talloc can be removed from Samba4 conflicts...
Comment 14 commit-hook freebsd_committer freebsd_triage 2024-02-28 14:30:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=06b59a3047f5d79b229135a0c9a64fe359ae13b0

commit 06b59a3047f5d79b229135a0c9a64fe359ae13b0
Author:     Denis Shaposhnikov <dsh@bamus.cz>
AuthorDate: 2024-02-28 14:28:06 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2024-02-28 14:30:15 +0000

    net/samba419: fix conflict with talloc

    PR:             276988

 net/samba419/Makefile  | 10 ++++++++--
 net/samba419/pkg-plist |  2 +-
 2 files changed, 9 insertions(+), 3 deletions(-)
Comment 15 Mikael Urankar freebsd_committer freebsd_triage 2024-02-28 14:31:50 UTC
Sorry for the delay.
Thanks!
Comment 16 Felix Palmen freebsd_committer freebsd_triage 2024-05-09 06:59:17 UTC
There's still a conflict with python enabled (which is required for AD_DC):

---
===>   Installing existing package /packages/All/talloc-2.3.4_1.pkg
[builder.home.palmen-it.de] Installing talloc-2.3.4_1...
pkg-static: talloc-2.3.4_1 conflicts with samba419-4.19.6 (installs files into the same place).  Problematic file: /usr/local/lib/python3.9/site-packages/talloc.cpython-39.so
---

Disabling PYTHON on devel/talloc works around this. Would it break things to never install python bindings for the bundled talloc?
Comment 17 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-08-01 14:58:22 UTC
This might get resoled once we transition to building unbundled Samba by default.