Clang 18 has become more stringent about narrowing in initializer lists, resulting in errors when building www/qt6-webengine: ../../../../../qtwebengine-everywhere-src-6.6.1/src/3rdparty/chromium/third_party/webrtc/pc/legacy_stats_collector.cc:192:54: error: non-constant-expression cannot be narrowed from type 'double' to 'float' in initializer list [-Wc++11-narrowing-const-reference] 192 | {StatsReport::kStatsValueNameTotalAudioEnergy, info.total_output_energy}, | ^~~~~~~~~~~~~~~~~~~~~~~~ ../../../../../qtwebengine-everywhere-src-6.6.1/src/3rdparty/chromium/third_party/webrtc/pc/legacy_stats_collector.cc:194:8: error: non-constant-expression cannot be narrowed from type 'double' to 'float' in initializer list [-Wc++11-narrowing-const-reference] 194 | info.total_output_duration}}; | ^~~~~~~~~~~~~~~~~~~~~~~~~~ Cherry-pick https://webrtc.googlesource.com/src/+/267f9bdd53 into the thirdparty directory, which fixes these errors.
Created attachment 248385 [details] www/qt6-webengine: fix build with clang 18
Ship it! Qt 6.6.2 is overdue for release, but the last word from the Qt Release Team in their meeting notes from 2024-02-06 [1] is it should be out at the beginning of this week. If you don't get around to committing this before Qt 6.6.2 is released, I'll do it before I start working on the update. [1] https://lists.qt-project.org/pipermail/releasing/2024-February/003009.html
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=0707093c0a5df15911d72c3b2e8001b3428f2e2e commit 0707093c0a5df15911d72c3b2e8001b3428f2e2e Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-02-12 08:17:56 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2024-02-13 18:00:05 +0000 www/qt6-webengine: fix build with clang 18 Clang 18 has become more stringent about narrowing in initializer lists, resulting in errors when building www/qt6-webengine: ../../../../../qtwebengine-everywhere-src-6.6.1/src/3rdparty/chromium/third_party/webrtc/pc/legacy_stats_collector.cc:192:54: error: non-constant-expression cannot be narrowed from type 'double' to 'float' in initializer list [-Wc++11-narrowing-const-reference] 192 | {StatsReport::kStatsValueNameTotalAudioEnergy, info.total_output_energy}, | ^~~~~~~~~~~~~~~~~~~~~~~~ ../../../../../qtwebengine-everywhere-src-6.6.1/src/3rdparty/chromium/third_party/webrtc/pc/legacy_stats_collector.cc:194:8: error: non-constant-expression cannot be narrowed from type 'double' to 'float' in initializer list [-Wc++11-narrowing-const-reference] 194 | info.total_output_duration}}; | ^~~~~~~~~~~~~~~~~~~~~~~~~~ Cherry-pick https://webrtc.googlesource.com/src/+/267f9bdd53 into the thirdparty directory, which fixes these errors. PR: 276997 MFH: 2024Q1 ...rty_webrtc_pc_legacy__stats__collector.cc (new) | 114 +++++++++++++++++++++ 1 file changed, 114 insertions(+)
A commit in branch 2024Q1 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=0569d74e5287a2933b0e19027f7524a4d247bf17 commit 0569d74e5287a2933b0e19027f7524a4d247bf17 Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-02-12 08:17:56 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2024-02-13 18:00:38 +0000 www/qt6-webengine: fix build with clang 18 Clang 18 has become more stringent about narrowing in initializer lists, resulting in errors when building www/qt6-webengine: ../../../../../qtwebengine-everywhere-src-6.6.1/src/3rdparty/chromium/third_party/webrtc/pc/legacy_stats_collector.cc:192:54: error: non-constant-expression cannot be narrowed from type 'double' to 'float' in initializer list [-Wc++11-narrowing-const-reference] 192 | {StatsReport::kStatsValueNameTotalAudioEnergy, info.total_output_energy}, | ^~~~~~~~~~~~~~~~~~~~~~~~ ../../../../../qtwebengine-everywhere-src-6.6.1/src/3rdparty/chromium/third_party/webrtc/pc/legacy_stats_collector.cc:194:8: error: non-constant-expression cannot be narrowed from type 'double' to 'float' in initializer list [-Wc++11-narrowing-const-reference] 194 | info.total_output_duration}}; | ^~~~~~~~~~~~~~~~~~~~~~~~~~ Cherry-pick https://webrtc.googlesource.com/src/+/267f9bdd53 into the thirdparty directory, which fixes these errors. PR: 276997 MFH: 2024Q1 (cherry picked from commit 0707093c0a5df15911d72c3b2e8001b3428f2e2e) ...rty_webrtc_pc_legacy__stats__collector.cc (new) | 114 +++++++++++++++++++++ 1 file changed, 114 insertions(+)
Thanks. Similar patches apply to other webkit instances such as chromium, I will submit separate tickets for those.