Bug 277152 - audio/cava: add pkg-message
Summary: audio/cava: add pkg-message
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joel Bodenmann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-19 01:58 UTC by Stefan Schlosser
Modified: 2024-04-18 19:46 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (vendion)


Attachments
patch (1.56 KB, patch)
2024-02-19 01:58 UTC, Stefan Schlosser
no flags Details | Diff
patch (1.70 KB, patch)
2024-02-19 09:21 UTC, Stefan Schlosser
jbo: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Schlosser 2024-02-19 01:58:18 UTC
Created attachment 248585 [details]
patch

Users without deeper knowledge about the audio systems OSS and sndio can be surprised when they try CAVA and the visualization doesn't work. Therefore provide a pkg-message which informs the user about required further setup and point them to the /usr/local/share/doc/cava/README.md documentation, which has detailed instructions.
Comment 1 Stefan Schlosser 2024-02-19 02:01:07 UTC
I don't know if the sole addition of the pkg-message needs an increase of the PORTREVISION. I believe not. If I am wrong then I can add it.
Comment 2 Joel Bodenmann freebsd_committer freebsd_triage 2024-02-19 03:46:03 UTC
A bump of PORTREVISION is desired here because the generated package is different.

From the porter's handbook:

> PORTREVISION must be increased each time a change is made to the port that changes the generated package in any way.

and

> Examples of when PORTREVISION must be bumped: Changes in the packing list or the install-time behavior of the package. For example, a change to a script which generates initial data for the package, like ssh(1) host keys.
Comment 3 Stefan Schlosser 2024-02-19 09:21:07 UTC
Created attachment 248595 [details]
patch

Thank you, I was unsure about it. Fixed it.
Comment 4 Joel Bodenmann freebsd_committer freebsd_triage 2024-02-19 15:09:59 UTC
Thanks!
Time to wait for maintainer-approval.
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-04-18 19:46:10 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1f326a00c927b8336c8742544b9814fcc25f7233

commit 1f326a00c927b8336c8742544b9814fcc25f7233
Author:     bsdcode <bsdcode@disroot.org>
AuthorDate: 2024-04-18 15:40:52 +0000
Commit:     Joel Bodenmann <jbo@FreeBSD.org>
CommitDate: 2024-04-18 19:45:09 +0000

    audio/cava: Add pkg-message

    Add a pkg-message to inform new users about required setup steps.

    PR:                     277152
    Approved by:            tcberner (mentor), Adam Jimerson <vendion@gmail.com> (maintainer)
    Differential Revision:  https://reviews.freebsd.org/D44676

 audio/cava/Makefile                   |  2 ++
 audio/cava/files/pkg-message.in (new) | 16 ++++++++++++++++
 2 files changed, 18 insertions(+)
Comment 6 Joel Bodenmann freebsd_committer freebsd_triage 2024-04-18 19:46:32 UTC
Committed - Thanks!