Bug 277218 - devel/gnulib not PREFIX-safe with DEVELOPER-mode on
Summary: devel/gnulib not PREFIX-safe with DEVELOPER-mode on
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-22 03:46 UTC by Mikhail T.
Modified: 2024-10-28 12:49 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail T. 2024-02-22 03:46:02 UTC 
Trying to build the port with DEVELOPER=yes triggers the below error for me, because my LOCALBASE is /opt, rather than the more commonly-used /usr/local:

Error: '/usr/local/bin/clisp' is an invalid shebang you need USES=shebangfix for 'share/gnulib/lib/uniname/gen-uninames.lisp'

The fix is simple enough. No PORTREVISION-rise is necessary, because the common case is not affected.

--- a/devel/gnulib/Makefile
+++ b/devel/gnulib/Makefile
@@ -15,7 +15,8 @@ LICENSE_COMB= multi
 BUILD_DEPENDS= ${LOCALBASE}/bin/makeinfo:print/texinfo
 
 USES=          cpe gmake perl5 shebangfix
-SHEBANG_FILES= check-module
+SHEBANG_FILES= check-module lib/uniname/gen-uninames.lisp
+SHEBANG_LANG=  clisp perl
 CPE_VENDOR=    gnu
 
 NO_ARCH=       yes
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2024-10-26 14:45:45 UTC 
Nice find.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-10-28 12:44:47 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f2964897c2eff821545c9eb2b9e2b03437c3c820

commit f2964897c2eff821545c9eb2b9e2b03437c3c820
Author:     Robert Clausecker <fuz@FreeBSD.org>
AuthorDate: 2024-10-26 14:45:50 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-10-28 12:42:02 +0000

    devel/gnulib: fix build with PREFIX != /usr/local

    Reported by:    Mikhail T. <freebsd-2024@virtual-estates.net>
    PR:             277218
    MFH:            2024Q4

 devel/gnulib/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-10-28 12:47:06 UTC 
A commit in branch 2024Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=481c5e45cb24499d0449ba19e24245283a064611

commit 481c5e45cb24499d0449ba19e24245283a064611
Author:     Robert Clausecker <fuz@FreeBSD.org>
AuthorDate: 2024-10-26 14:45:50 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-10-28 12:46:12 +0000

    devel/gnulib: fix build with PREFIX != /usr/local

    Reported by:    Mikhail T. <freebsd-2024@virtual-estates.net>
    PR:             277218
    MFH:            2024Q4

    (cherry picked from commit f2964897c2eff821545c9eb2b9e2b03437c3c820)

 devel/gnulib/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2024-10-28 12:49:55 UTC 
Thank you for your report.