Bug 277276 - x11/xfce4-terminal: fix wrong assert and make "unsafe paste" dialog working again
Summary: x11/xfce4-terminal: fix wrong assert and make "unsafe paste" dialog working a...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-xfce (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-24 09:25 UTC by Marek Zarychta
Modified: 2024-02-26 18:51 UTC (History)
2 users (show)

See Also:
madpilot: maintainer-feedback+
madpilot: merge-quarterly-

Attachments
patch with fix (1.07 KB, patch)
2024-02-24 09:25 UTC, Marek Zarychta 		no flags Details | Diff
patch with fix (1.14 KB, patch)
2024-02-24 11:01 UTC, Marek Zarychta 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Marek Zarychta 2024-02-24 09:37:28 UTC 
I believe a lot of FreeBSD desktop users are affected, XFCE4 seems to be popular DE.
Comment 2 Marek Zarychta 2024-02-24 11:01:22 UTC 
Created attachment 248715 [details]
patch with fix

Bump PORTREVISION
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2024-02-24 17:37:27 UTC 
Hi!

Thanks for reporting the issue, and providing a fix. You patch looks fine.

I'm going to test this shortly and commit it as soon as I'm done.
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2024-02-24 17:49:06 UTC 
Correction, no need to merge to quarterly, since the version there is not affected.
Comment 5 Marek Zarychta 2024-02-24 17:57:58 UTC 
(In reply to Guido Falsi from comment #3)

Thanks for working on this. Rebuilding x11/xfce4-terminal with this patch fixed the issue for me. The port builds fine, at least on 15.0-CURRENT[1].
  
1. http://pkg.dom.potoki.eu/data/builder-head-default/2024-02-24_15h57m18s/logs/xfce4-terminal-1.1.2_1.log
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-02-26 18:38:04 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e5b7a328929b8cf7803fde8761cff6046b833f1c

commit e5b7a328929b8cf7803fde8761cff6046b833f1c
Author:     Marek Zarychta <zarychtam@plan-b.pwste.edu.pl>
AuthorDate: 2024-02-26 18:34:47 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2024-02-26 18:37:01 +0000

    x11/xfce4-terminal: Fix "unsafe paste dialog" functionality

    Import patch from upstream to fix a bug in the latest relase that
    prevents the "unsafe paste dialog" feature from working.

    PR:             277276
    btained from:   https://gitlab.xfce.org/apps/xfce4-terminal/-/commit/177fda86451cdeaaea8ed409e6d711b670699a97

 x11/xfce4-terminal/Makefile | 4 ++++
 x11/xfce4-terminal/distinfo | 4 +++-
 2 files changed, 7 insertions(+), 1 deletion(-)
Comment 7 Guido Falsi freebsd_committer freebsd_triage 2024-02-26 18:50:00 UTC 
Patch committed. Thanks!
Comment 8 Marek Zarychta 2024-02-26 18:51:01 UTC 
(In reply to Guido Falsi from comment #7)
Thank you for committing !