Bug 277328 - games/freedoko: Update to version 0.8.0
Summary: games/freedoko: Update to version 0.8.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-26 11:12 UTC by Michael Straube
Modified: 2024-09-30 14:10 UTC (History)
3 users (show)

See Also:

Attachments
git patch (79.50 KB, patch)
2024-02-26 11:12 UTC, Michael Straube 		no flags Details | Diff
patch v2 (79.56 KB, patch)
2024-02-29 17:55 UTC, Michael Straube 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Straube 2024-02-26 11:12:52 UTC 
Created attachment 248758 [details]
git patch

new file:
files/patch-Makefile.install.directories
Comment 1 Michael Straube 2024-02-29 17:55:13 UTC 
Created attachment 248828 [details]
patch v2

Added in patch v2:
LDFLAGS_i386=	-Wl,-znotext
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-20 16:03:58 UTC 
Port don't have the maintainer. Do you want to become the maintainer?
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2024-09-27 13:45:01 UTC 
For future patches, please consider the following items:

 - Please make the manual optional (behind a DOCS options) so source builders
   can avoid having to install texlive to build this package.

 - package seems not to obey CFLAGS and CXXFLAGS, which it needs to.  This could
   also be your build system not printing the full build commands, which it
   should be configured to do.

 - static replacements must be done with patch files, REINPLACE_CMD is for
   dynamic replacements only.

 - the flip dependency seems not to actually be necessary.  Please remove it if
   it is not.  That said, if it is needed, check if dos2unix does the trick as
   well, as it's more commonly installed.

 - Please consider becoming the maintainer for this port.

Is there a changelog for this update?
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-09-30 14:09:15 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b4ac6ffb5f153166c46c8cb28d53ff05e5521e90

commit b4ac6ffb5f153166c46c8cb28d53ff05e5521e90
Author:     Michael Straube <michael.straube@posteo.de>
AuthorDate: 2024-02-26 10:17:28 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-09-30 14:02:04 +0000

    games/freedoko: update to 0.8.0

     - depend on dos2unix over flip

    Changelog: https://free-doko.sourceforge.net/Download.html

    PR:             277328

 games/freedoko/Makefile                            |   94 +-
 games/freedoko/distinfo                            |    6 +-
 .../files/patch-Makefile.install.directories (new) |   15 +
 games/freedoko/files/patch-src_Makefile (new)      |   11 +
 games/freedoko/pkg-descr                           |    2 +
 games/freedoko/pkg-plist                           | 1052 ++++++--------------
 6 files changed, 352 insertions(+), 828 deletions(-)
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2024-09-30 14:10:46 UTC 
Thank you for your contribution.