Bug 277387 - irc/ircproxy: updates to 1.3.8, changes MASTERSITES
Summary: irc/ircproxy: updates to 1.3.8, changes MASTERSITES
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Gleb Popov
URL:
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2024-02-29 03:27 UTC by Chris Hutchinson
Modified: 2024-03-02 13:51 UTC (History)
1 user (show)

See Also:


Attachments
updates irc/ircproxy to 1.3.8, changes MASTERSITES (2.23 KB, patch)
2024-02-29 03:27 UTC, Chris Hutchinson
portmaster: maintainer-approval+
Details | Diff
patch against irc/ircproxy (2.12 KB, patch)
2024-03-02 00:23 UTC, Chris Hutchinson
portmaster: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2024-02-29 03:27:02 UTC
Created attachment 248821 [details]
updates irc/ircproxy to 1.3.8, changes MASTERSITES
Comment 1 Gleb Popov freebsd_committer freebsd_triage 2024-03-01 18:36:49 UTC
19 CFLAGS+=	-I${LOCALBASE}/include
20 LDFLAGS+=	-L${LOCALBASE}/lib

This is exactly what USES=localbase:ldflags do, so you can get rid of it.

I'm a bit worried about the license change. Are you sure you can do that? I'm not a lawyer at all.
Comment 2 Chris Hutchinson 2024-03-02 00:23:27 UTC
Created attachment 248864 [details]
patch against irc/ircproxy

> 19 CFLAGS+=	-I${LOCALBASE}/include
> 20 LDFLAGS+=	-L${LOCALBASE}/lib

> This is exactly what USES=localbase:ldflags do, so you can get rid of it.
Yep. Sure is. Sorry I missed that.

> I'm a bit worried about the license change. Are you sure you can do that? I'm not a lawyer at all.
I'm not a lawyer either. But I come from a family of them. Which helps. :)
I only changed it as all the headers I encountered, were Lesser.
I grepped them now, and found a couple that weren't. So I reverted it.

This patch should scratch your itches. )

Thanks!

--Chris
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-03-02 13:51:32 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d3720279f222d61b7db0353069befcd84bd070db

commit d3720279f222d61b7db0353069befcd84bd070db
Author:     Chris Hutchinson <portmaster@bsdforge.com>
AuthorDate: 2024-03-02 13:44:58 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2024-03-02 13:50:02 +0000

    irc/ircproxy: Update to 1.3.8

    PR:             277387

 irc/ircproxy/Makefile | 29 +++++++++++++----------------
 irc/ircproxy/distinfo |  5 +++--
 2 files changed, 16 insertions(+), 18 deletions(-)