Bug 277439 - x11-toolkits/fltk: 1.3.9 fails to expose an API
Summary: x11-toolkits/fltk: 1.3.9 fails to expose an API
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks: 277433
  Show dependency treegraph
 
Reported: 2024-03-02 22:56 UTC by Hiroo Ono
Modified: 2024-12-26 18:56 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (danfe)


Attachments
add patch to FL/x.H (1.07 KB, patch)
2024-03-02 22:56 UTC, Hiroo Ono
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hiroo Ono 2024-03-02 22:56:30 UTC
Created attachment 248884 [details]
add patch to FL/x.H

In FL/x.H, the class Fl_XFont_On_Demand is not labelled FL_EXPORT which makes it not exposed in the library. It makes x11-toolkits/py-fltk fail on import as reported in the bug 277433.
The patch fixes it.

Reported upstream: https://github.com/fltk/fltk/issues/922
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-12-26 18:49:36 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b603333e3d4c2e74e2404b1d75f776cb46b15216

commit b603333e3d4c2e74e2404b1d75f776cb46b15216
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2024-12-26 18:47:36 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2024-12-26 18:47:36 +0000

    x11-toolkits/fltk: update this port to the latest version 1.3.10

    FLTK 1.3.10 is a maintenance release with minor enhancements and
    bug fixes.  Particularly, Fl_XFont_On_Demand class was previously
    not labeled FL_EXPORT, which made it not exposed in the library,
    in turn breaking `x11-toolkits/py-fltk' port and other consumers.

    There are no new ABI features and thus it is 100% compatible with
    releases 1.3.5-1.3.9.  This is intended to be the last release of
    the 1.3.x series.

    PR:     277433, 277439

 x11-toolkits/fltk/Makefile | 4 +---
 x11-toolkits/fltk/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 6 deletions(-)
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2024-12-26 18:56:39 UTC
The fix was included in the latest 1.3.10 version which is now in the ports tree, thanks!