Bug 277648 - multimedia/libopenshot: fix OPTIONS and audio output device selection
Summary: multimedia/libopenshot: fix OPTIONS and audio output device selection
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on: 277647
Blocks:
  Show dependency tree / graph
 
Reported: 2024-03-12 05:44 UTC by Tatsuki Makino
Modified: 2024-05-06 23:23 UTC (History)
1 user (show)

See Also:

Attachments
patch for multimedia/libopenshot (5.14 KB, patch)
2024-03-12 05:44 UTC, Tatsuki Makino 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tatsuki Makino 2024-03-12 05:44:32 UTC 
Created attachment 249110 [details]
patch for multimedia/libopenshot

Documents that require doxygen have been separated into DOXYGEN option.
It is off by default.
This may be able to be subpackaged later.
This should fix an issue where no matter what we choose, we could only output audio to the default sink.
Incidentally, the configure output for libraries that need to be linked on FreeBSD may be a bit more elegant :)
PORTREVISION has already been bumped in the patch.
Comment 1 Tatsuki Makino 2024-03-12 05:47:51 UTC 
In particular, it is a fix that has become necessary to make JACK work well.
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2024-05-06 11:26:54 UTC 
"make stage-qa" show it need "LIB_DEPENDS+=libpython${PYTHON_VER}${PYTHON_ABIVER}.so:lang/python${PYTHON_SUFFIX}".

Also I suggest to bump multimedia/openshot.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-05-06 15:06:39 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=985f2bd893ba7faacf425f999796bdc1db9bbfa5

commit 985f2bd893ba7faacf425f999796bdc1db9bbfa5
Author:     Tatsuki Makino <tatsuki_makino@hotmail.com>
AuthorDate: 2024-05-06 15:00:48 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-05-06 15:05:33 +0000

    multimedia/{,lib}openshot: fix OPTIONS and audio output device selection

    Documents that require doxygen have been separated into DOXYGEN option.
    It is off by default.
    This should fix an issue where no matter what we choose, we could only
    output audio to the default sink.
    In particular, it is a fix that has become necessary to make JACK work well.
    Fixed stage-qa error - link with libpython.

    PR:     277648

 multimedia/libopenshot/Makefile                    | 30 ++++++++++++----------
 .../libopenshot/files/patch-src_CMakeLists.txt     | 20 ++++++++++-----
 .../patch-src_Qt_AudioPlaybackThread.cpp (new)     | 22 ++++++++++++++++
 multimedia/openshot/Makefile                       |  2 +-
 4 files changed, 53 insertions(+), 21 deletions(-)
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2024-05-06 15:07:39 UTC 
Thanks for patch!
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2024-05-06 15:11:35 UTC 
BTW, can you help with fix compilation of the multimedia/libopenshot with ffmpeg 7.0 (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=278705#c6)?
Comment 6 Tatsuki Makino 2024-05-06 23:23:28 UTC 
Thank you for committing and small adjustment of them.

(In reply to Vladimir Druzenko from comment #5)
Seems like a simple matter of changing where to put the values, but it seems like major surgery is needed on it to coexist with the old version...