Bug 277698 - textproc/fzf: Update to 0.54.3
Summary: textproc/fzf: Update to 0.54.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Larry Rosenman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-14 15:29 UTC by Andrew Fyfe
Modified: 2024-08-05 02:36 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (dmgk)


Attachments
update textproc/fzf to 0.48.0 (5.90 KB, patch)
2024-03-14 15:29 UTC, Andrew Fyfe
no flags Details | Diff
update textproc/fzf to 0.48.1 (5.90 KB, patch)
2024-03-20 15:28 UTC, Andrew Fyfe
no flags Details | Diff
update textproc/fzf to 0.50.0 (5.92 KB, patch)
2024-04-19 21:23 UTC, Andrew Fyfe
no flags Details | Diff
update textproc/fzf to 0.52.1 (1.93 KB, patch)
2024-05-26 21:32 UTC, Andrew Fyfe
no flags Details | Diff
update textproc/fzf to 0.52.1 (5.92 KB, patch)
2024-05-26 21:37 UTC, Andrew Fyfe
no flags Details | Diff
update textproc/fzf to 0.54.0 (6.55 KB, patch)
2024-07-15 16:37 UTC, Andrew Fyfe
no flags Details | Diff
update textproc/fzf to 0.54.1 (6.55 KB, patch)
2024-07-21 09:17 UTC, Andrew Fyfe
no flags Details | Diff
update textproc/fzf to 0.54.1 (improved pkg-message) (7.04 KB, patch)
2024-07-21 09:35 UTC, Andrew Fyfe
no flags Details | Diff
update textproc/fzf to 0.54.1 (embeded version number fix) (7.30 KB, patch)
2024-07-21 09:57 UTC, Andrew Fyfe
no flags Details | Diff
update textproc/fzf to 0.54.3 (7.38 KB, patch)
2024-08-02 11:11 UTC, Andrew Fyfe
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fyfe 2024-03-14 15:29:21 UTC
Created attachment 249165 [details]
update textproc/fzf to 0.48.0

This is to update textproc/fzf to the 0.48.0

I've removed the included shell completions as they are now embedded in the fzf binary, pkg-message has been updated with the appropriate instructions.

https://github.com/junegunn/fzf/releases/tag/0.48.0
Comment 1 Andrew Fyfe 2024-03-20 15:28:13 UTC
Created attachment 249342 [details]
update textproc/fzf to 0.48.1

https://github.com/junegunn/fzf/releases/tag/0.48.1
Comment 4 Andrew Fyfe 2024-05-26 21:37:49 UTC
Created attachment 251002 [details]
update textproc/fzf to 0.52.1

Replaced last patch (0.52.1), I rebased it on the wrong branch.

https://github.com/junegunn/fzf/releases/tag/0.51.0
https://github.com/junegunn/fzf/releases/tag/0.52.0
https://github.com/junegunn/fzf/releases/tag/0.52.1
Comment 5 Andrew Fyfe 2024-07-15 16:37:15 UTC
Created attachment 252083 [details]
update textproc/fzf to 0.54.0

update textproc/fzf to 0.54.0

https://github.com/junegunn/fzf/releases/tag/0.53.0
https://github.com/junegunn/fzf/releases/tag/v0.54.0
Comment 6 Marie Helene Kvello-Aune 2024-07-21 08:46:14 UTC
I was going to submit a patch to bring this port up to 0.54.1, and found this ticket instead.  

Andrew Fyfe's patch for 0.54.0 needs a minor change to incorporate 0.54.1:

Makefile
```
DISTVERSION=0.54.1
COMMIT_ID=50fa90d
```

distinfo:

```
TIMESTAMP = 1721419797
SHA256 (go/textproc_fzf/junegunn-fzf-v0.54.1_GH0/go.mod) = 1c46fd5ef317a4c3c5691a433ad9a2c903c4dae980ff996cb5ee243564ecf166
SIZE (go/textproc_fzf/junegunn-fzf-v0.54.1_GH0/go.mod) = 496
SHA256 (go/textproc_fzf/junegunn-fzf-v0.54.1_GH0/junegunn-fzf-v0.54.1_GH0.tar.gz) = 62358508afdf3840ab63ae06fbc86382a407362cf9491788e6aa52215a98b68f
SIZE (go/textproc_fzf/junegunn-fzf-v0.54.1_GH0/junegunn-fzf-v0.54.1_GH0.tar.gz) = 292157
```

relnotes 0.54.1: https://github.com/junegunn/fzf/releases/tag/v0.54.1
Comment 7 Andrew Fyfe 2024-07-21 09:17:10 UTC
Created attachment 252202 [details]
update textproc/fzf to 0.54.1
Comment 8 Andrew Fyfe 2024-07-21 09:35:36 UTC
Created attachment 252203 [details]
update textproc/fzf to 0.54.1 (improved pkg-message)

Forgot to include the improvements to pkg-message (version targeted upgrade messages)
Comment 9 Andrew Fyfe 2024-07-21 09:57:56 UTC
Created attachment 252204 [details]
update textproc/fzf to 0.54.1 (embeded version number fix)

One minor fix, upstream don't increment the embeded version number in main.go for patch release they use go build flag. Go build flag added to set the correct version number.
Comment 11 Larry Rosenman freebsd_committer freebsd_triage 2024-08-05 02:23:55 UTC
take - Maintainer Timeout
Comment 12 Larry Rosenman freebsd_committer freebsd_triage 2024-08-05 02:35:58 UTC
Committed, thanks
Comment 13 commit-hook freebsd_committer freebsd_triage 2024-08-05 02:36:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=37f26d4beaad6bce695af3d9ca206b7d51859137

commit 37f26d4beaad6bce695af3d9ca206b7d51859137
Author:     Larry Rosenman <ler@FreeBSD.org>
AuthorDate: 2024-08-05 02:34:00 +0000
Commit:     Larry Rosenman <ler@FreeBSD.org>
CommitDate: 2024-08-05 02:34:00 +0000

    textproc/fzf:  update to 0.54.3

    PR:     277698
    Approved by:    Maintainer Timeout (>3 months)
    Reported by:    Andrew Fyfe <andrew@neptune-one.net>

 textproc/fzf/Makefile                              | 28 ++--------
 textproc/fzf/distinfo                              | 10 ++--
 .../fzf/files/patch-shell_completion.bash (gone)   | 11 ----
 .../fzf/files/patch-shell_completion.zsh (gone)    | 11 ----
 textproc/fzf/files/pkg-message.in (gone)           | 10 ----
 textproc/fzf/pkg-message (new)                     | 62 ++++++++++++++++++++++
 6 files changed, 72 insertions(+), 60 deletions(-)