Bug 277728 - audio/mixxx: update to 2.4.1
Summary: audio/mixxx: update to 2.4.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jose Alonso Cardenas Marquez
URL: https://mixxx.org/news/2024-05-09-mix...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-15 21:49 UTC by Charlie Li
Modified: 2024-06-24 18:23 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (acm)
vishwin: maintainer-feedback? (acm)


Attachments
v0 (48.78 KB, patch)
2024-03-15 21:49 UTC, Charlie Li
no flags Details | Diff
v1 (50.37 KB, patch)
2024-06-23 16:32 UTC, Charlie Li
acm: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Charlie Li freebsd_committer freebsd_triage 2024-03-15 21:49:51 UTC
Created attachment 249202 [details]
v0

Probably needs another once-over on dependencies and whatnot. Everything seems to work as intended, especially vinyl control to external mixer which is what my setup consists of. Testing framework exposed/enabled, but some of the tests time out.
Comment 1 Marcin Cieślak 2024-05-25 08:26:19 UTC
Comment on attachment 249202 [details]
v0

https://github.com/mixxxdj/mixxx/pull/13247 (accepted) and https://github.com/mixxxdj/mixxx/pull/13257 have been filed upstream to use standard SQL single quotes only and hopefully will become part of the next 2.4.x release.

This patch backports this to 2.3.6 release.

PORTREVISION bumped, as the port might suddenly stops working when the user updates sqlite3 with no double quote strings literals support.
Comment 2 Marcin Cieślak 2024-05-27 10:53:10 UTC
I suspect the patch patch-lib_kaitai_kaitaistream.cpp might not be working properly, please refer to https://github.com/kaitai-io/kaitai_struct_cpp_stl_runtime/pull/48
If we compile without that patch, it seems to work better.
Comment 3 Charlie Li freebsd_committer freebsd_triage 2024-06-23 16:32:31 UTC
Created attachment 251650 [details]
v1

update to 2.4.1

Includes upstream commit for CMake to allow taglib 2.0 and https://github.com/mixxxdj/mixxx/pull/12854 to address data loss issues.
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-06-24 18:22:17 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ba9b3654b49eb576cef0d7e7606b200c5a8379cf

commit ba9b3654b49eb576cef0d7e7606b200c5a8379cf
Author:     Charlie Li <vishwin@FreeBSD.org>
AuthorDate: 2024-06-24 18:18:00 +0000
Commit:     Charlie Li <vishwin@FreeBSD.org>
CommitDate: 2024-06-24 18:21:20 +0000

    audio/mixxx: update to 2.4.1

    Event: BSDCan 2024
    Event: SouthEast LinuxFest 2024
    Event: ARRL/RAC Field Day 2024
    PR: 277728
    Tested by: Marcin Cieślak <saper[at]saper[dot]info>
    Approved by: acm (maintainer)

 audio/mixxx/Makefile  |  37 ++++---
 audio/mixxx/distinfo  |  12 +--
 audio/mixxx/pkg-plist | 281 ++++++++++++++++++++++----------------------------
 3 files changed, 151 insertions(+), 179 deletions(-)