Bug 277777 - audio/emms: update 18 → 20.1
Summary: audio/emms: update 18 → 20.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Joseph Mingrone
URL: https://git.savannah.gnu.org/cgit/emm...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-18 12:00 UTC by Älven
Modified: 2024-08-08 13:42 UTC (History)
3 users (show)

See Also:


Attachments
[PATCH] audio/emms: Update to 19 (2.63 KB, patch)
2024-03-18 12:32 UTC, Älven
no flags Details | Diff
[PATCH] audio/emms: update 18.2 → 19 (2.71 KB, patch)
2024-05-26 17:41 UTC, Älven
no flags Details | Diff
[PATCH] audio/emms: update 18 → 19 (2.71 KB, patch)
2024-05-26 17:57 UTC, Älven
no flags Details | Diff
[PATCH] audio/emms: update 18 → 19 (2.71 KB, patch)
2024-05-26 18:06 UTC, Älven
no flags Details | Diff
[PATCH] audio/emms: update 19 → 20.1 (5.80 KB, patch)
2024-08-07 11:25 UTC, Älven
no flags Details | Diff
[PATCH] audio/emms: update 18 → 20.1 (6.11 KB, patch)
2024-08-07 11:30 UTC, Älven
alster: maintainer-approval? (emacs)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Älven 2024-03-18 12:00:31 UTC

    
Comment 1 Älven 2024-03-18 12:32:01 UTC
Created attachment 249260 [details]
[PATCH] audio/emms: Update to 19

Test, please.
Comment 2 Älven 2024-05-26 17:41:08 UTC
Created attachment 250989 [details]
[PATCH] audio/emms: update 18.2 → 19
Comment 3 Älven 2024-05-26 17:57:59 UTC
Created attachment 250990 [details]
[PATCH] audio/emms: update 18 → 19
Comment 4 Älven 2024-05-26 18:06:10 UTC
Created attachment 250992 [details]
[PATCH] audio/emms: update 18 → 19
Comment 5 Älven 2024-08-07 11:25:10 UTC
Created attachment 252585 [details]
[PATCH] audio/emms: update 19 → 20.1
Comment 6 Älven 2024-08-07 11:30:09 UTC
Created attachment 252586 [details]
[PATCH] audio/emms: update 18 → 20.1
Comment 7 Joseph Mingrone freebsd_committer freebsd_triage 2024-08-07 16:23:42 UTC
Thanks for submitting.  Your patch looks good to me in that:

- all the `poudriere testport` that I ran looked good
- run-time tests look good [0].

The port does not have a maintainer, and it seems to be very low-maintenance. Are you up for being the new maintainer?

[0]

I used this configuration and played a few sample files.

(require 'emms-setup)
(emms-all)
(setq emms-player-list '(emms-player-mpv)
      emms-info-functions '(emms-info-native))
Comment 8 Älven 2024-08-07 16:51:13 UTC
Thank you for your kind offer :)
I would be glad and learn how to be a maintainer for the first time!
This may be my first maintained port. I hope I could do it. I like to.

Älven
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-08-08 13:40:55 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a840d97b169d365df5b20c2a307d4485b357ac93

commit a840d97b169d365df5b20c2a307d4485b357ac93
Author:     Älven <alster@vinterdalen.se>
AuthorDate: 2024-08-07 16:24:22 +0000
Commit:     Joseph Mingrone <jrm@FreeBSD.org>
CommitDate: 2024-08-08 13:39:24 +0000

    audio/emms: Update to 20.1 and set new maintainer

    Changelog:      https://git.savannah.gnu.org/cgit/emms.git/tree/NEWS
    PR:             277777

 audio/emms/Makefile  |  5 ++---
 audio/emms/distinfo  |  6 +++---
 audio/emms/pkg-descr | 13 ++++++++-----
 audio/emms/pkg-plist | 22 ++++++++++++++++------
 4 files changed, 29 insertions(+), 17 deletions(-)
Comment 10 Joseph Mingrone freebsd_committer freebsd_triage 2024-08-08 13:42:18 UTC
Committed.  Thanks for submitting and offering to maintain the port.