Bug 277802 - net/yate: convert AMR codec to opencore one
Summary: net/yate: convert AMR codec to opencore one
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks: 277803
  Show dependency tree / graph
 
Reported: 2024-03-19 07:20 UTC by Tatsuki Makino
Modified: 2025-02-18 14:43 UTC (History)
2 users (show)

See Also:

Attachments
experiment patch for net/yate (4.41 KB, patch)
2024-03-19 07:20 UTC, Tatsuki Makino 		no flags Details | Diff
experiment patch for net/yate (4.85 KB, patch)
2024-05-21 04:44 UTC, Tatsuki Makino 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tatsuki Makino 2024-03-19 07:20:27 UTC 
Created attachment 249297 [details]
experiment patch for net/yate

I have no knowledge of what it is used for on this, though :)
Let it use opencore AMR NB codec.
Comment 1 Tatsuki Makino 2024-05-21 04:44:45 UTC 
Created attachment 250843 [details]
experiment patch for net/yate

The patch was rebuilt to match the current version.
Also, correction of missing plist corrections.
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2025-02-13 19:20:09 UTC 
Did you test this patch?  Is the audio ok with it applied?
Comment 3 Tatsuki Makino 2025-02-13 21:25:50 UTC 
I don't know :)

In the first place, I don't even know where and how this is being used.
I hope it will be tested by someone who knows about it.
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2025-02-13 21:26:24 UTC 
Yeah... good luck.
Maybe you can contact upstream about this.
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2025-02-14 15:46:19 UTC 
CC'ed kbowling@ who touched this port last.  Maybe he can test your patch.
Comment 6 commit-hook freebsd_committer freebsd_triage 2025-02-18 14:28:55 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=92fc8d2fcd5f4314a6f73faa9afa95b29f972301

commit 92fc8d2fcd5f4314a6f73faa9afa95b29f972301
Author:     Tatsuki Makino <tatsuki_makino@hotmail.com>
AuthorDate: 2025-02-13 19:18:45 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2025-02-18 14:16:17 +0000

    net/yate: convert AMR codec to opencore one

    This would allow us to sunset audio/libamrnb.

    PR:             277803, 277802

 net/yate/Makefile                                 |  8 ++++----
 net/yate/files/patch-configure.ac                 | 24 ++++++++++++++++++++++-
 net/yate/files/patch-modules_amrnbcodec.cpp (new) | 23 ++++++++++++++++++++++
 net/yate/files/patch-modules_efrcodec.cpp (new)   | 23 ++++++++++++++++++++++
 net/yate/pkg-plist                                |  4 ++--
 5 files changed, 75 insertions(+), 7 deletions(-)
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2025-02-18 14:43:00 UTC 
Committed your patch.  It's probably fine.