Bug 277866 - www/redmine50 broken with rubygem-roadie-rails-rails61 3.1.0
Summary: www/redmine50 broken with rubygem-roadie-rails-rails61 3.1.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: Mikael Urankar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-21 14:54 UTC by gessel
Modified: 2024-03-22 07:40 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (mikael)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description gessel 2024-03-21 14:54:44 UTC
Building www/redmine50 5.0.8 on 14.0-RELEASE #0 releng/14.0-n265380-f9716eee8ab4 with Poudriere the build fails with:

===>   redmine50-5.0.8 depends on package: rubygem-roadie-rails-rails61>=3.0.0 - not found
===>   Installing existing package /packages/All/rubygem-roadie-rails-rails61-3.1.0.pkg
[FBSD_14-0-R-default-job-01] Installing rubygem-roadie-rails-rails61-3.1.0...
[FBSD_14-0-R-default-job-01] `-- Installing rubygem-roadie-5.2.1...
[FBSD_14-0-R-default-job-01] |   `-- Installing rubygem-css_parser-1.16.0...
[FBSD_14-0-R-default-job-01] |   `-- Extracting rubygem-css_parser-1.16.0: ....... done
[FBSD_14-0-R-default-job-01] `-- Extracting rubygem-roadie-5.2.1: .......... done
[FBSD_14-0-R-default-job-01] Extracting rubygem-roadie-rails-rails61-3.1.0: .......... done
===>   redmine50-5.0.8 depends on package: rubygem-roadie-rails-rails61>=3.0.0 - found
===>   Returning to build of redmine50-5.0.8

but:

Your Gemfile lists the gem redcarpet (>= 3.5.1) more than once.
You should probably keep only one of them.
Remove any duplicate entries and specify the gem only once.
While it's not a problem now, it could cause errors if you change the version of one of them later.
Could not find gem 'roadie-rails (~> 3.0.0)' in cached gems or installed
locally.

The source contains the following gems matching 'roadie-rails':
  * roadie-rails-3.1.0
*** Error code 7

The only make.conf option that seem relevant are:
DEFAULT_VERSIONS+=ruby=3.1
DEFAULT_VERSIONS+=mysql=10.11m

Building directly in ports /usr/ports/www/redmine50 # make install yields

cp -f /usr/ports/www/redmine50/files/markdown.rb /usr/ports/www/redmine50/work/stage/usr/local/www/redmine/bundler.d
cp -f /usr/ports/www/redmine50/files/mysql.rb /usr/ports/www/redmine50/work/stage/usr/local/www/redmine/bundler.d
cp -f /usr/ports/www/redmine50/files/mini_magick.rb /usr/ports/www/redmine50/work/stage/usr/local/www/redmine/bundler.d
(cd /usr/ports/www/redmine50/work/stage/usr/local/www/redmine && /bin/rm -f Gemfile.lock && bundle install --local)
Don't run Bundler as root. Installing your bundle as root will break this application for all non-root users on this machine.
Your Gemfile lists the gem redcarpet (>= 3.5.1) more than once.
You should probably keep only one of them.
Remove any duplicate entries and specify the gem only once.
While it's not a problem now, it could cause errors if you change the version of one of them later.
Could not find gem 'roadie-rails (~> 3.0.0)' in cached gems or installed locally.

The source contains the following gems matching 'roadie-rails':
  * roadie-rails-3.1.0
*** Error code 7

Stop.
make[1]: stopped in /usr/ports/www/redmine50


/usr/ports/www/redmine50 # pkg version -v | grep roadie
rubygem-roadie-5.2.1               =   up-to-date with port
rubygem-roadie-rails-rails61-3.1.0 =   up-to-date with port
Comment 1 gessel 2024-03-21 19:23:28 UTC
modifying patch-Gemfile as

-gem 'roadie-rails', (Gem.ruby_version < Gem::Version.new('2.6.0') ? '~> 2.2.0' : '~> 3.0.0')
+gem 'roadie-rails', (Gem.ruby_version < Gem::Version.new('2.6.0') ? '~> 2.2.0' : '~> 3.0')

results in a successful build.  Is there a known break between 3.0.0 and 3.1.0? Are breaks expected before 4.0? I can't fully verify that it is working, but install happens as expected.

The changes from 3.0.0 don't appear obviously breaking:
https://github.com/Mange/roadie-rails/compare/v3.0.0...v3.1.0
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-03-22 07:36:24 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c0b038e0bb3669e1414267dd1cc052aa96bd7d05

commit c0b038e0bb3669e1414267dd1cc052aa96bd7d05
Author:     Mikael Urankar <mikael@FreeBSD.org>
AuthorDate: 2024-03-22 07:30:43 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2024-03-22 07:35:03 +0000

    www/redmine50: Fix build rubygem-roadie-rails-rails61 3.1.0

    PR:             277866

 www/redmine50/files/patch-Gemfile | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
Comment 3 Mikael Urankar freebsd_committer freebsd_triage 2024-03-22 07:39:56 UTC
(In reply to gessel from comment #1)
From https://github.com/Mange/roadie-rails:
This project follows Semantic Versioning. (https://semver.org/)

Given a version number MAJOR.MINOR.PATCH, increment the:
    MAJOR version when you make incompatible API changes
    MINOR version when you add functionality in a backward compatible manner
    PATCH version when you make backward compatible bug fixes

So 3.1 is compatible with 3.0