Bug 277909 - devel/llvm*: Remove unnecessary C/CFLAGS definitions
Summary: devel/llvm*: Remove unnecessary C/CFLAGS definitions
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-23 16:29 UTC by Daniel Engberg
Modified: 2024-04-23 22:14 UTC (History)
0 users

See Also:

Attachments
Patch for llvm (5.40 KB, patch)
2024-03-23 16:29 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-03-23 16:29:35 UTC 
Created attachment 249429 [details]
Patch for llvm

As of https://cgit.freebsd.org/ports/commit/Mk/Uses/cmake.mk?id=3c5189a0fd4c82addfb659024bf28c5006bf88f7 there's no need to define DNDEBUG manually
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-04-14 19:54:15 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1f50c8e24264be1d64a96e84536e2e1d59b63180

commit 1f50c8e24264be1d64a96e84536e2e1d59b63180
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-04-14 19:32:42 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-04-14 19:52:59 +0000

    devel/llvm*: Remove unnecessary C/CFLAGS definitions

    As of 3c5189a0fd4c82addfb659024bf28c5006bf88f7
    there's no need to define DNDEBUG manually

    PR:             277909
    Approved by:    portmgr (maintainer timeout, 2+ weeks)

 devel/llvm11/Makefile | 5 -----
 devel/llvm12/Makefile | 5 -----
 devel/llvm13/Makefile | 5 -----
 devel/llvm14/Makefile | 5 -----
 devel/llvm15/Makefile | 5 -----
 devel/llvm16/Makefile | 5 -----
 devel/llvm17/Makefile | 5 -----
 devel/llvm18/Makefile | 5 -----
 8 files changed, 40 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-04-23 22:14:41 UTC 
A commit in branch 2024Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3645478a263b3af06d158a2fadebab0490c0abb0

commit 3645478a263b3af06d158a2fadebab0490c0abb0
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-04-14 19:32:42 +0000
Commit:     Brooks Davis <brooks@FreeBSD.org>
CommitDate: 2024-04-23 22:14:14 +0000

    devel/llvm*: Remove unnecessary C/CFLAGS definitions

    As of 3c5189a0fd4c82addfb659024bf28c5006bf88f7
    there's no need to define DNDEBUG manually

    PR:             277909
    Approved by:    portmgr (maintainer timeout, 2+ weeks)

    (cherry picked from commit 1f50c8e24264be1d64a96e84536e2e1d59b63180)

 devel/llvm11/Makefile | 5 -----
 devel/llvm12/Makefile | 5 -----
 devel/llvm13/Makefile | 5 -----
 devel/llvm14/Makefile | 5 -----
 devel/llvm15/Makefile | 5 -----
 devel/llvm16/Makefile | 5 -----
 devel/llvm17/Makefile | 5 -----
 devel/llvm18/Makefile | 5 -----
 8 files changed, 40 deletions(-)