Bug 278061 - devel/xtensa-esp32-elf: Rename port in tree to: devel/xtensa-esp32-elf-legacy
Summary: devel/xtensa-esp32-elf: Rename port in tree to: devel/xtensa-esp32-elf-legacy
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Craig Leres
URL:
Keywords:
Depends on:
Blocks: 278062
  Show dependency treegraph
 
Reported: 2024-03-31 09:24 UTC by O. Hartmann
Modified: 2024-09-24 10:24 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (leres)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description O. Hartmann 2024-03-31 09:24:35 UTC
Tomoyuki Sakurai maintains a far more recent variant of this toolchain for Arduino/ESP32 develeopment based on a more recent toolchain (gcc 12 instead of gcc 5 in the recent FreeBSD port).

See here:

https://github.com/trombik/xtensa-esp32-elf
Comment 1 Craig Leres freebsd_committer freebsd_triage 2024-04-03 21:34:32 UTC
I'd rather not rename this port.

The external project this port supports has been actively migrating to a newer esp-idf; once that work is complete I will update this port to a newer version of the toolchain. Meanwhile I don't want to make changes that would orphan existing users of it.

Please propose a name for a v2022.01.29 version of a port and I'll work on adding it.
Comment 2 O. Hartmann 2024-04-09 19:39:53 UTC
So this breaks the "logic" of the FreeBSD community's ports collection?
Comment 3 Bernhard Froehlich freebsd_committer freebsd_triage 2024-09-14 11:56:23 UTC
(In reply to Craig Leres from comment #1)
Why is it a problem to rename this port? There will be a MOVED entry and life will continue afer the rename as it was before.

This port is legacy so why we cannot call it so?
Comment 4 Bernhard Froehlich freebsd_committer freebsd_triage 2024-09-14 12:04:13 UTC
The situation has been stalled like this for at least 4 years now. We need to figure (or at least talk) this out. No offense in any direction but I think we can do better going forward.
Comment 5 O. Hartmann 2024-09-14 15:47:26 UTC
Maybe it would be worth to put the discussion on a more public display.

In the meanwhile, ESP-IDF 5.3 is out and a toolchain esp-13.2.0_20240530 (covering gcc13) as well as esp-14.2.0_20240906 (covering gcc14).

The maintainer of the FreeBSD toolchain on github, Tomoyuki Sakurai has also provided an updated port. Both RISCV32 ans XtensaESP32 are covered. Maybe this would be an adequate starting point not to interfere with this port.

Those already developing ESP32 utilizing IDF 5.0 - 5.2 will probably use Linux as the major dev platform, so

devel/xtensa-esp-elf
devel/riscv32-esp-elf 

could coexist with this port.
Comment 6 Bernhard Froehlich freebsd_committer freebsd_triage 2024-09-15 05:54:35 UTC
Yeah, I have seen trombiks new ports as well and I am currently pushing them through my CI.

The ports look very clean and seem to be well prepared for the portstree. I will also contact him directly before I commit something.
Comment 7 O. Hartmann 2024-09-20 15:44:44 UTC
(In reply to Bernhard Froehlich from comment #6)

Taking trombiks port and build it via poudriere on 14-STABLE and recent CURRENT, I see no problem. But the port rejects to build via 

"portmaster" and "make all"

on several CURRENT and 14-STABLE (both  OS versions recent builds, buildworld daily). It would be nice if you have the chance yourself to build the port via "make" and/or portmaster. In my case, on CURRENT, see below.

[...]

[ALL  ]    checking for xtensa-esp-elf-gcc... /usr/ports/devel/xtensa-esp-elf/work-idf53/crosstool-NG-esp-13.2.0_20240530/.build/xtensa-esp-elf/build/build-cc-gcc-core/./gcc/xgcc -B/usr/ports/devel/xtensa-esp-elf/work-idf53/crosstool-NG-esp-13.2.0_20240530/.build/xtensa-esp-elf/build/build-cc-gcc-core/./gcc/ -B/usr/ports/devel/xtensa-esp-elf/work-idf53/crosstool-NG-esp-13.2.0_20240530/.build/xtensa-esp-elf/buildtools/xtensa-esp-elf/bin/ -B/usr/ports/devel/xtensa-esp-elf/work-idf53/crosstool-NG-esp-13.2.0_20240530/.build/xtensa-esp-elf/buildtools/xtensa-esp-elf/lib/ -isystem /usr/ports/devel/xtensa-esp-elf/work-idf53/crosstool-NG-esp-13.2.0_20240530/.build/xtensa-esp-elf/buildtools/xtensa-esp-elf/include -isystem /usr/ports/devel/xtensa-esp-elf/work-idf53/crosstool-NG-esp-13.2.0_20240530/.build/xtensa-esp-elf/buildtools/xtensa-esp-elf/sys-include  -mdynconfig=xtensa_esp32.so
[ERROR]    checking for suffix of object files... configure: error: in `/usr/ports/devel/xtensa-esp-elf/work-idf53/crosstool-NG-esp-13.2.0_20240530/.build/xtensa-esp-elf/build/build-cc-gcc-core/xtensa-esp-elf/esp32/libgcc':
[ERROR]    configure: error: cannot compute suffix of object files: cannot compile
[ALL  ]    See `config.log' for more details
[ERROR]    make[1]: *** [Makefile:13136: configure-target-libgcc] Error 1
[ALL  ]    make[1]: Leaving directory '/usr/ports/devel/xtensa-esp-elf/work-idf53/crosstool-NG-esp-13.2.0_20240530/.build/xtensa-esp-elf/build/build-cc-gcc-core'
[ERROR]  
[ERROR]  >>
[ERROR]  >>  Build failed in step 'Installing core C gcc compiler'
[ERROR]  >>        called in step '(top-level)'
[ERROR]  >>
[ERROR]  >>  Error happened in: CT_DoExecLog[scripts/functions@377]
[ERROR]  >>        called from: do_gcc_core_backend[scripts/build/cc/gcc.sh@711]
[ERROR]  >>        called from: do_cc_core[scripts/build/cc/gcc.sh@212]
[ERROR]  >>        called from: main[scripts/crosstool-NG.sh@699]
[ERROR]  >>
[ERROR]  >>  For more info on this error, look at the file: 'build.log'
[ERROR]  >>  There is a list of known issues, some with workarounds, in:
[ERROR]  >>      https://crosstool-ng.github.io/docs/known-issues/
[ERROR]  >>
[ERROR]  >> NOTE: Your configuration includes features marked EXPERIMENTAL.
[ERROR]  >> Before submitting a bug report, try to reproduce it without enabling
[ERROR]  >> any experimental features. Otherwise, you'll need to debug it
[ERROR]  >> and present an explanation why it is a bug in crosstool-NG - or
[ERROR]  >> preferably, a fix.
[ERROR]  >>
[ERROR]  >>  If you feel this is a bug in crosstool-NG, report it at:
[ERROR]  >>      https://github.com/crosstool-ng/crosstool-ng/issues/
[ERROR]  >>
[ERROR]  >>  Make sure your report includes all the information pertinent to this issue.
[ERROR]  >>  Read the bug reporting guidelines here:
[ERROR]  >>      http://crosstool-ng.github.io/support/
[ERROR]  
[ERROR]  (elapsed: 21:06.42)
gmake: *** [ct-ng:261: build] Error 2
*** Error code 2
Comment 8 Bernhard Froehlich freebsd_committer freebsd_triage 2024-09-22 12:49:15 UTC
(In reply to O. Hartmann from comment #7)

I can reproduce this issue on my build box. Will check if I can figure out what is going wrong here.
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-09-23 19:45:39 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=771e57d671d9c859005e32f5eba6abc75bee5dd5

commit 771e57d671d9c859005e32f5eba6abc75bee5dd5
Author:     Craig Leres <leres@FreeBSD.org>
AuthorDate: 2024-09-23 19:44:29 +0000
Commit:     Craig Leres <leres@FreeBSD.org>
CommitDate: 2024-09-23 19:44:29 +0000

    devel/xtensa-esp32-elf: Update to 13.2.0_20240530, rename to xtensa-esp-elf

    This updates the toolchain to gcc 13.2.0 as used by versions 5.2.2,
    5.3.0, and 5.3.1 of the Espressif esp-idf.

    The crosstool.config for xtensa-esp32-esp is invalid for this version
    (and is removed in esp-14.2.0_20240906 via 6269489 -- "samples:
    remove obsolete xtensa-esp32XX-elf targets") so switch to xtensa-esp-esp
    and rename port to match.

    This update removes the final dependency on gcc10.

    PR:             278061 278062

 MOVED                                              |    1 +
 devel/xtensa-esp-elf/Makefile (new)                |  116 ++
 devel/xtensa-esp-elf/distinfo (new)                |   21 +
 devel/xtensa-esp-elf/files/crosstool.config (new)  |   57 +
 devel/xtensa-esp-elf/pkg-descr (new)               |    4 +
 devel/xtensa-esp-elf/pkg-plist (new)               | 2111 ++++++++++++++++++++
 devel/xtensa-esp32-elf/Makefile (gone)             |  108 -
 devel/xtensa-esp32-elf/distinfo (gone)             |   23 -
 .../files/0001-gdb-7.12.1.patch (gone)             |   46 -
 devel/xtensa-esp32-elf/pkg-descr (gone)            |    4 -
 devel/xtensa-esp32-elf/pkg-plist (gone)            | 1555 --------------
 11 files changed, 2310 insertions(+), 1736 deletions(-)
Comment 10 O. Hartmann 2024-09-24 10:24:25 UTC
Nice ;-) Thank you.