Bug 278083 - security/gnutls: Add KTLS option and a few improvements
Summary: security/gnutls: Add KTLS option and a few improvements
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tijl Coosemans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-31 22:58 UTC by Daniel Engberg
Modified: 2025-01-20 22:32 UTC (History)
2 users (show)

See Also:
tijl: maintainer-feedback+


Attachments
Patch for gnutls (2.44 KB, patch)
2024-03-31 22:58 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-03-31 22:58:36 UTC
Created attachment 249609 [details]
Patch for gnutls

* Switch to DISTFILES (cosmetic)
* Do some light rearrangement of Makefile for better readability and consistency
* Remove --disable-guile (configure: WARNING: unrecognized options: --disable-guile)
* Add --without-included-libtasn1
* Add KTLS option
https://lists.gnupg.org/pipermail/gnutls-help/2023-November/004837.html
See also https://gitlab.archlinux.org/archlinux/packaging/packages/gnutls/-/blob/main/config?ref_type=heads

Compile and runtime tested on FreeBSD 14.0-RELEASE (amd64) (make, make check-plist, make test)
Poudriere testport OK 14.0-RELEASE (amd64)
Poudriere testport OK 13.2-RELEASE (amd64)

Thanks for working on this!
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-03-31 22:59:21 UTC
Forgot to add, --disable-rpath is also added
Comment 2 Tijl Coosemans freebsd_committer freebsd_triage 2024-04-02 07:51:50 UTC
Approved, but can you also remove gnutls-guile from INFO?
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-04-02 20:55:27 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9efa900590948cb91abb0c3fe886a7d742fed5fb

commit 9efa900590948cb91abb0c3fe886a7d742fed5fb
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-04-02 20:52:15 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-04-02 20:52:20 +0000

    security/gnutls: Add KTLS option and a few improvements

    * Switch to DISTFILES
    * Do some light rearrangement of Makefile for better readability and
      consistency
    * Remove --disable-guile from CONFIGURE_ARGS
    * Add --without-included-libtasn1 to CONFIGURE_ARGS
    * Add KTLS option
      https://lists.gnupg.org/pipermail/gnutls-help/2023-November/004837.html
      See also https://gnutls.org/manual/html_node/Enabling_002fDisabling-system_002facceleration-protocols.html#Enabling-KTLS

    PR:             278083
    Reviewed by:    tijl

 security/gnutls/Makefile | 44 +++++++++++++++++++++++++-------------------
 1 file changed, 25 insertions(+), 19 deletions(-)
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2024-04-02 21:19:46 UTC
Committed, thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-10-28 18:37:45 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=7200d90644ba61d63e6fec33855bba5d3b7eb7bd

commit 7200d90644ba61d63e6fec33855bba5d3b7eb7bd
Author:     Alan Somers <asomers@FreeBSD.org>
AuthorDate: 2024-10-28 15:14:06 +0000
Commit:     Alan Somers <asomers@FreeBSD.org>
CommitDate: 2024-10-28 18:36:10 +0000

    ktls.4: note that security/gnutls now supports ktls

    [skip ci]

    PR:             278083
    MFC after:      2 weeks
    Sponsored by:   ConnectWise
    Reviewed by:    diizzy
    Differential Revision: https://reviews.freebsd.org/D47310

 share/man/man4/ktls.4 | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2025-01-20 16:23:14 UTC
A commit in branch stable/14 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=6203d08e7a3aaaa1e8e4c1e78b26065ec2902d8d

commit 6203d08e7a3aaaa1e8e4c1e78b26065ec2902d8d
Author:     Alan Somers <asomers@FreeBSD.org>
AuthorDate: 2024-10-28 15:14:06 +0000
Commit:     Alan Somers <asomers@FreeBSD.org>
CommitDate: 2025-01-20 16:22:21 +0000

    ktls.4: note that security/gnutls now supports ktls

    [skip ci]

    PR:             278083
    Sponsored by:   ConnectWise
    Reviewed by:    diizzy
    Differential Revision: https://reviews.freebsd.org/D47310

    (cherry picked from commit 7200d90644ba61d63e6fec33855bba5d3b7eb7bd)

    ktls.4: note that there are multiple openssl ports with KTLS knobs

    [skip ci]

    Reported by:    "Herbert J. Skuhra" <herbert@gojira.at>
    Sponsored by:   ConnectWise

    (cherry picked from commit 1e4da42a36d5cf44bacf0e261626b69a4761f0cc)

 share/man/man4/ktls.4 | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
Comment 7 Älven 2025-01-20 19:18:31 UTC
Thanks for KTLS support!
Comment 8 commit-hook freebsd_committer freebsd_triage 2025-01-20 22:32:07 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=1bcf8494d934bda897ca52e8dbbebec55e940e68

commit 1bcf8494d934bda897ca52e8dbbebec55e940e68
Author:     Alan Somers <asomers@FreeBSD.org>
AuthorDate: 2024-10-28 15:14:06 +0000
Commit:     Alan Somers <asomers@FreeBSD.org>
CommitDate: 2025-01-20 22:30:57 +0000

    ktls.4: note that security/gnutls now supports ktls

    [skip ci]

    PR:             278083
    Sponsored by:   ConnectWise
    Reviewed by:    diizzy
    Differential Revision: https://reviews.freebsd.org/D47310

    (cherry picked from commit 7200d90644ba61d63e6fec33855bba5d3b7eb7bd)

    ktls.4: note that there are multiple openssl ports with KTLS knobs

    [skip ci]

    Reported by:    "Herbert J. Skuhra" <herbert@gojira.at>
    Sponsored by:   ConnectWise

    (cherry picked from commit 1e4da42a36d5cf44bacf0e261626b69a4761f0cc)

 share/man/man4/ktls.4 | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)