Bug 278103 - irc/epic5: Port cleanup
Summary: irc/epic5: Port cleanup
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-01 15:44 UTC by epic
Modified: 2024-04-04 18:00 UTC (History)
2 users (show)

See Also:

Attachments
Patch to upgrade irc/epic5 to 2.1.12_2 (1.20 KB, patch)
2024-04-01 15:44 UTC, epic 		eduardo: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description epic 2024-04-01 15:44:18 UTC 
Created attachment 249640 [details]
Patch to upgrade irc/epic5 to 2.1.12_2

This patch updates the irc/epic5 port to remove the -O2 CFLAGS adjustment now that irc/epic5 is fully C99 compliant, syncs the MASTER_SITES with irc/epic4, and general style updates.
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2024-04-04 17:31:15 UTC 
- Fixing maintainer approval to +, implicit to maintainer
Comment 2 Nuno Teixeira freebsd_committer freebsd_triage 2024-04-04 17:57:17 UTC 
Related to changing PORTVERSION -> DISTVERSION, it's not good for git blame to do it on a non port update, i.e., it's preferable to do that change when port gets updated.
Fixed in commit.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-04-04 17:58:13 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a7e1f7792d3f723f00767fb1f7544a5087ebcdd1

commit a7e1f7792d3f723f00767fb1f7544a5087ebcdd1
Author:     epic <epic@dsllsn.net>
AuthorDate: 2024-04-04 17:51:39 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2024-04-04 17:57:40 +0000

    irc/epic5: Port cleanup

    This patch updates the irc/epic5 port to remove the -O2 CFLAGS adjustment
    now that irc/epic5 is fully C99 compliant, syncs the MASTER_SITES with
    irc/epic4, and general style updates.

    PR:             278103

 irc/epic5/Makefile | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2024-04-04 18:00:47 UTC 
Committed, thanks!