Bug 278247 - devel/py-versioningit: Update to 3.1.0
Summary: devel/py-versioningit: Update to 3.1.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dan Langille
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-08 06:41 UTC by wen
Modified: 2024-04-08 23:39 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (dvl)

Attachments
Update to 3.1.0 (1.25 KB, text/plain)
2024-04-08 06:41 UTC, wen 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description wen 2024-04-08 06:41:41 UTC 
Created attachment 249822 [details]
Update to 3.1.0

Update to 3.1.0
Comment 1 Dan Langille freebsd_committer freebsd_triage 2024-04-08 12:57:47 UTC 
FYI, the attached patch contained trailing control-M on each line and would not apply cleanly.

After fixing that, the Makefile patch would not apply.  Looking at the patch, it contains spaces after the =, where they should be tabs. I'm guessing this was copy/pasted.

I usually create patches via:

git diff . > ~/tmp/patch-devel-py-versioningit.mine

Then attach that file directly to the ticket.
Comment 2 Dan Langille freebsd_committer freebsd_triage 2024-04-08 13:41:14 UTC 
See https://docs.freebsd.org/en/books/fdp-primer/overview/

Patch generated with git format-patch will include author identity and email addresses, making it easier for developers to apply (with git am) and give proper credit.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-04-08 13:42:44 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ed5808d4cd97cc9053f8ace1def4e88bfb2bbaef

commit ed5808d4cd97cc9053f8ace1def4e88bfb2bbaef
Author:     Dan Langille <dvl@FreeBSD.org>
AuthorDate: 2024-04-08 13:39:53 +0000
Commit:     Dan Langille <dvl@FreeBSD.org>
CommitDate: 2024-04-08 13:42:24 +0000

    devel/py-versioningit: Update to 3.1.0

    PR:             278247

 devel/py-versioningit/Makefile | 4 ++--
 devel/py-versioningit/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)
Comment 4 Dan Langille freebsd_committer freebsd_triage 2024-04-08 13:53:45 UTC 
Thank you. No worries about the patch. Just stuff to keep in mind for next time. Thanks again.
Comment 5 wen 2024-04-08 23:39:15 UTC 
(In reply to Dan Langille from comment #2)
Thank you !