Bug 278301 - games/crossfire-client: Update to 1.75.3
Summary: games/crossfire-client: Update to 1.75.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Zsolt Udvari
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-11 05:13 UTC by Kevin Zheng
Modified: 2024-09-05 06:08 UTC (History)
1 user (show)

See Also:


Attachments
Patch (1.51 KB, patch)
2024-04-11 05:13 UTC, Kevin Zheng
no flags Details | Diff
Updated patch (1.76 KB, patch)
2024-08-24 23:01 UTC, Kevin Zheng
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Zheng 2024-04-11 05:13:44 UTC
Created attachment 249890 [details]
Patch

games/crossfire-client: Update to 1.75.3

WWW: https://sourceforge.net/p/crossfire/crossfire-client/ci/v1.75.3/tree/ChangeLog

**Added**

- Add 'mapedit' command to launch map editor on current map
- Implement smooth lighting for new Pixmap (Cairo) renderer
- Add additional protocol debugging flags
- Automatically set 'away' if idle for some time
- Add pop-up action menu when left-clicking on items. Can be disabled with the inv_menu configuration option
- Add default bindings for 'reply' and 'get all'
- Add "scriptkillall" command

**Changed**

- Lighting defaults to per-pixel lighting
- Improve movement prediction and enable it by default
Comment 1 Zsolt Udvari freebsd_committer freebsd_triage 2024-08-24 16:37:19 UTC
Did you test on poudriere?

====> Running Q/A tests (stage-qa)
Error: /usr/local/bin/crossfire-client-gtk2 is linked to /usr/local/lib/libpng16.so.16 from graphics/png but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libpng16.so:graphics/png
Error: /usr/local/bin/crossfire-client-gtk2 is linked to /usr/local/lib/libSM.so.6 from x11/libSM but it is not declared as a dependency
Warning: you need USE_XORG+=sm
Error: /usr/local/bin/crossfire-client-gtk2 is linked to /usr/local/lib/libICE.so.6 from x11/libICE but it is not declared as a dependency
Warning: you need USE_XORG+=ice
Error: /usr/local/bin/crossfire-client-gtk2 is linked to /usr/local/lib/libX11.so.6 from x11/libX11 but it is not declared as a dependency
Warning: you need USE_XORG+=x11
Error: /usr/local/bin/crossfire-client-gtk2 is linked to /usr/local/lib/libXext.so.6 from x11/libXext but it is not declared as a dependency
Warning: you need USE_XORG+=xext
Warning: you might not need LIB_DEPENDS on libSDL2_mixer.so
Warning: you might not need LIB_DEPENDS on libSDL2.so
Comment 2 Kevin Zheng 2024-08-24 17:11:42 UTC
Thanks for getting back on this. No, though I was able to check these myself with DEVELOPER=yes in /etc/make.conf.

I believe that at some point these were transitive dependencies that USE_GNOME=gtk20 brought in? But I'll update the patches with the missing dependencies and update you here.
Comment 3 Kevin Zheng 2024-08-24 23:01:35 UTC
Created attachment 253068 [details]
Updated patch

Please find updated patch attached, thanks.
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-09-05 06:08:07 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=42793bc04f53ee1ed58d58bd81e0688e5060c805

commit 42793bc04f53ee1ed58d58bd81e0688e5060c805
Author:     Kevin Zheng <kevinz5000@gmail.com>
AuthorDate: 2024-09-05 06:03:27 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2024-09-05 06:06:41 +0000

    games/crossfire-client: Update to 1.75.3

    Add graphics/png to LIB_DEPENDS.
    Add xorg to USES and set USE_XORG.
    Switch to DISTVERSION.

    Changelog:
    https://sourceforge.net/projects/crossfire/files/crossfire-client/1.75.3/

    PR:             278301
    Approved by:    submitter is maintainer

 games/crossfire-client/Makefile | 13 +++++++------
 games/crossfire-client/distinfo |  6 +++---
 2 files changed, 10 insertions(+), 9 deletions(-)
Comment 5 Zsolt Udvari freebsd_committer freebsd_triage 2024-09-05 06:08:36 UTC
Committed, thanks!