Bug 278457 - x11/lightdm: Fix VT/user switching
Summary: x11/lightdm: Fix VT/user switching
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL: https://github.com/canonical/lightdm/...
Keywords: patch
Depends on:
Blocks:
 
Reported: 2024-04-19 10:31 UTC by Tijl Coosemans
Modified: 2024-04-21 13:31 UTC (History)
3 users (show)

See Also:
madpilot: maintainer-feedback+


Attachments
patch-src_vt.c (2.65 KB, patch)
2024-04-19 10:31 UTC, Tijl Coosemans
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tijl Coosemans freebsd_committer freebsd_triage 2024-04-19 10:31:49 UTC
Created attachment 250085 [details]
patch-src_vt.c

The first xserver runs on VT9.  When you run the command "dm-tool lock" lightdm starts a new xserver with a greeter on VT10.  When you unlock the session lightdm needs to switch back to VT9 and this fails currently.  Similar for commands like "dm-tool switch-to-greeter" and "dm-tool switch-to-user USERNAME".

This is a patch to put in x11/lightdm/files.  It ports src/vt.c so lightdm can do VT switching on FreeBSD.
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2024-04-19 11:48:27 UTC
Hi,

Since I recently committed a few patches to lightdm I can take a look at this in the next few days.


Maybe this could also be merged upstream, but canonical (the upstream entity) has strict rules about submissions, so it would be easier if you submitted this yourself to them, signing their agreement.

Could you try doing that too?
Comment 2 Tijl Coosemans freebsd_committer freebsd_triage 2024-04-19 12:01:58 UTC
(In reply to Guido Falsi from comment #1)
If you've already signed their agreement then please submit it under your name.  It seems overkill for me to sign it for a one-off patch.
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2024-04-19 12:12:41 UTC
(In reply to Tijl Coosemans from comment #2)

No problem!

Thanks for granting explicit authorization.
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-04-21 13:28:54 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=96b6500ac4d9de0d37c54823d4d0764890718f74

commit 96b6500ac4d9de0d37c54823d4d0764890718f74
Author:     Tijl Coosemans <tijl@FreeBSD.org>
AuthorDate: 2024-04-21 13:27:18 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2024-04-21 13:27:18 +0000

    x11/lightdm: Fix VT/user switching

    Submitted upstream: https://github.com/canonical/lightdm/pull/353

    PR:     278457

 x11/lightdm/Makefile                   |  2 +-
 x11/lightdm/files/patch-src_vt.c (new) | 99 ++++++++++++++++++++++++++++++++++
 2 files changed, 100 insertions(+), 1 deletion(-)
Comment 5 Guido Falsi freebsd_committer freebsd_triage 2024-04-21 13:31:24 UTC
Patch committed. Thanks!