Bug 278471 - math/abella: update 2.0.7 → 2.0.8
Summary: math/abella: update 2.0.7 → 2.0.8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL: https://github.com/abella-prover/abel...
Keywords:
Depends on: 279334
Blocks:
  Show dependency treegraph
 
Reported: 2024-04-20 01:39 UTC by Älven
Modified: 2024-05-27 19:43 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments
abella.diff (9.72 KB, patch)
2024-05-21 12:27 UTC, Benjamin Jacobs
no flags Details | Diff
abella.diff (5.47 KB, patch)
2024-05-27 19:33 UTC, Benjamin Jacobs
freebsd: maintainer-approval? (yuri)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Älven 2024-04-20 01:39:07 UTC

    
Comment 1 Älven 2024-04-20 01:39:59 UTC
=======================<phase: build          >============================
===== env: DEVELOPER_MODE=yes STRICT_DEPENDS=yes USER=root UID=0 GID=0
===>  Building for abella-2.0.8
dune build src/abella.exe src/abella_doc.exe src/abella_dep.exe
File "dune-project", line 1, characters 11-15:
1 | (lang dune 3.11)
               ^^^^
Error: Version 3.11 of the dune language is not supported.
Supported versions of this extension in version 3.11 of the dune language:
- 1.0 to 1.12
- 2.0 to 2.9
- 3.0 to 3.7
gmake: *** [Makefile:7: all] Error 1
===> Compilation failed unexpectedly.
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2024-04-20 02:05:31 UTC
The requested dune version isn't yet available in ports.
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2024-04-27 05:58:50 UTC
I'd close this for now, since this update needs dune to be updated, and we don't know when is this going to happen.

Thanks for the report.
Comment 4 Benjamin Jacobs 2024-05-21 12:27:35 UTC
Created attachment 250853 [details]
abella.diff

Dune 3.11 isn't a requirement per-se, Abella builds fine with our dune version.

It is however missing yojson, which I've also packaged in the attached patch. That and some ugly patching to work on our older cmdliner (which may cause some subtle difference in the cli behaviour).

Feel free to ping cmdliner's maintaineur for that...
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2024-05-26 22:28:51 UTC
Reopening.
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2024-05-26 22:46:12 UTC
The build failed with this patch:

=======================<phase: build          >============================
===== env: DEVELOPER_MODE=yes STRICT_DEPENDS=yes USER=nobody UID=65534 GID=65534
===>  Building for abella-2.0.8    
dune build src/abella.exe src/abella_doc.exe src/abella_dep.exe 
File "src/dune", line 28, characters 0-62: 
28 | (menhir                       
29 |   (modules parser)            
30 |   (infer true)
31 |   (flags --explain))
/usr/local/bin/menhir: unknown option '--infer-write-query'.
Usage: /usr/local/bin/menhir <options> <filenames>
  --base <basename>                Specifies a base name for the output file(s)
  --canonical                      Construct a canonical Knuth LR(1) automaton
  --cmly                           Write a .cmly file
  --comment                        Include comments in the generated code
  --compare-errors <filename>      (used twice) Compare two .messages files.
Comment 7 Benjamin Jacobs 2024-05-27 19:33:49 UTC
Created attachment 251027 [details]
abella.diff

That error occurs when using an older menhir. I've modified the patch to further constraint menhir's version. And dropped yojson which is now in the tree :) thanks!
Comment 8 Yuri Victorovich freebsd_committer freebsd_triage 2024-05-27 19:43:19 UTC
Committed.

Thank you for your contribution!
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-05-27 19:43:52 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c596e126717974126f15561c3f53d74f773377dc

commit c596e126717974126f15561c3f53d74f773377dc
Author:     Benjamin Jacobs <freebsd@dev.thsi.be>
AuthorDate: 2024-05-27 19:42:11 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2024-05-27 19:42:52 +0000

    math/abella: update 2.0.7 → 2.0.8

    PR:     278471

 math/abella/Makefile                             | 12 +++++-----
 math/abella/distinfo                             |  6 ++---
 math/abella/files/patch-dune-project (new)       |  8 +++++++
 math/abella/files/patch-src_abella.ml (new)      | 25 ++++++++++++++++++++
 math/abella/files/patch-src_abella__dep.ml (new) | 13 ++++++++++
 math/abella/files/patch-src_abella__doc.ml (new) | 30 ++++++++++++++++++++++++
 6 files changed, 85 insertions(+), 9 deletions(-)