278490 – audio/sdl2_mixer: Improvements to port

Bug 278490 - audio/sdl2_mixer: Improvements to port

Summary: audio/sdl2_mixer: Improvements to port

Status:	Closed FIXED

Alias:	None

Product:	Ports & Packages
Classification:	Unclassified
Component:	Individual Port(s) (show other bugs)
Version:	Latest
Hardware:	Any Any

Importance:	--- Affects Only Me
Assignee:	Dmitry Marakasov

URL:
Keywords:

Depends on:
Blocks:

Reported:	2024-04-20 21:34 UTC by Daniel Engberg
Modified:	2024-04-22 18:46 UTC (History)
CC List:	1 user (show)

See Also:

Flags:	bugzilla: maintainer-feedback? (amdmi3)

Attachments
Patch for sdl2_mixer (4.06 KB, patch) 2024-04-20 21:34 UTC, Daniel Engberg	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Daniel Engberg freebsd_committer

2024-04-20 21:34:39 UTC

Created attachment 250115 [details]
Patch for sdl2_mixer

* Use upstream release archive
* Reduce I/O by excluding unused content in repo
* Define pkgconfig as a dependency
* Sort menu options
* Sort CMake options
* Remove stray OGG definition from OPTIONS_RADIO

No functional change

Comment 1 Daniel Engberg freebsd_committer

2024-04-20 21:37:47 UTC

Regarding release archive/tarball,
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github

Comment 2 Dmitry Marakasov freebsd_committer

2024-04-22 18:23:46 UTC

Options refactoring accepted. pkgconfig dependency is not needed.

Comment 3 Daniel Engberg freebsd_committer

2024-04-22 18:42:38 UTC

Multiple dependencies uses pkgconfig ?
See https://github.com/libsdl-org/SDL_mixer/blob/release-2.8.0/cmake/FindOpusFile.cmake for example
https://cmake.org/cmake/help/latest/module/FindPkgConfig.html

Comment 4 Dmitry Marakasov freebsd_committer

2024-04-22 18:45:57 UTC

I've only looked into CMakeLists.txt, you're right.

Comment 5 commit-hook freebsd_committer

2024-04-22 18:46:05 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6384812843afff595ff21a8b3378e3321bc64e7c

commit 6384812843afff595ff21a8b3378e3321bc64e7c
Author:     Dmitry Marakasov <amdmi3@FreeBSD.org>
AuthorDate: 2024-04-22 18:45:19 +0000
Commit:     Dmitry Marakasov <amdmi3@FreeBSD.org>
CommitDate: 2024-04-22 18:45:50 +0000

    audio/sdl2_mixer: Add missing pkgconfig dependency

    PR:             278490
    Submitted by:   diizzy

 audio/sdl2_mixer/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)