Created attachment 250131 [details] git-format patch Update to 4.2.1 Changes: - Version 4.1.3 -> 4.2.1 Release notes at <https://www.mpich.org/2024/04/17/mpich-4-2-1-released/> - Add MAINTAINER - Remove bash dependency. I hope that I'm not causing a regression, but the dependency no longer seems necessary. mpicc now seems to work fine with sh. I couldn't find a specific test case for why the dependency was added in 24b3efeb6116e - Restore the www doc folder. I'm not sure why it was removed in the first place - Remove bugfix for src/pm/hydra/lib/tools/bootstrap/external/slurm_query_node_list.c as it was fixed upstream QA: - portlint: no new warnings - poudriere: OK
I see problems with pkg-plist, with options not being isolated properly. Don't commit yet, I'll fix this.
Created attachment 250154 [details] Improved patch with better OPTIONS handling in pkg-plist Used panopticum to create a better pkg-plist
Ready for commit
Hello, Some options macros disappeared from pkg-plist: %%EXEC%% %%EXECGFORKER%% %%FORTRAN%% %%HYDRA%% ... Could you take a look?
Created attachment 250190 [details] 0001-net-mpich-Update-to-4.2.1.patch You're right. Somehow I managed to submit the wrong patch twice. Hopefully this is OK now.
Hello, With PORTDOCS defined in Makefile we can get rid of the long plist %%PORTDOCS%%%%DOCSDIR%%/... It can be defined as: PORTDOCS= * (to include all docs installed) PORTDOCS= file1 filen dir1 dirn (for selected docs) This is just an sugestion, since listing docs files in plist is correct too. Cheers
(In reply to Nuno Teixeira from comment #6) (...) https://docs.freebsd.org/en/books/porters-handbook/book/#install-documentation
(In reply to Nuno Teixeira from comment #6) Thanks for the suggestion. That would make the plist easier to diff and manage from release to release. Let me have a look at it.
Created attachment 250198 [details] 0001-net-mpich-Update-to-4.2.1.patch with PORTDOCS in Makefile Changes: - Version 4.1.3 -> 4.2.1 Release notes at <https://www.mpich.org/2024/04/17/mpich-4-2-1-released/> - Add MAINTAINER - Remove bash dependency - Restore the www doc folder - Remove bugfix for slurm_query_node_list.c as it was fixed upstream QA: - portlint: no new warnings - poudriere: OK
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=298eb16d8c74bffcb08ca7dd537bc36971ae9b91 commit 298eb16d8c74bffcb08ca7dd537bc36971ae9b91 Author: Laurent <laurent.chardon@gmail.com> AuthorDate: 2024-04-24 19:24:40 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2024-04-24 19:31:15 +0000 net/mpich: Update to 4.2.1 - Submitter becomes maintainer - Remove bash dependency - Restore the www doc folder - Remove bugfix for slurm_query_node_list.c as it was fixed upstream While I'm here: - Remove GNU_CONFIGURE_MANPREFIX after 9fd7ee1cdf6c ChangeLog: https://www.mpich.org/2024/04/17/mpich-4-2-1-released/ PR: 278505 net/mpich/Makefile | 13 ++-- net/mpich/distinfo | 6 +- ...trap_external_slurm__query__node__list.c (gone) | 11 ---- net/mpich/files/patch-test_mpi_configure.ac (new) | 19 ++++++ net/mpich/pkg-plist | 69 +++++++++++++++++++--- 5 files changed, 89 insertions(+), 29 deletions(-)
Nice work! Committed, thank you!