Bug 278581 - www/p5-HTTP-Tiny: split HTTPS option, adding new CERTS option
Summary: www/p5-HTTP-Tiny: split HTTPS option, adding new CERTS option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-25 14:16 UTC by Dan Langille
Modified: 2024-04-28 11:37 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Add new option CERTS (1.09 KB, patch)
2024-04-25 14:16 UTC, Dan Langille 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Langille freebsd_committer freebsd_triage 2024-04-25 14:16:02 UTC 
Created attachment 250224 [details]
Add new option CERTS

Make www/p5-Mozilla-CA optional but on by default

I'd like to make www/p5-Mozilla-CA optional, but enabled by default.

There are circumstances when we don't want www/p5-Mozilla-CA to be installed. This patch permits that.
Comment 1 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-04-28 05:21:32 UTC 
(In reply to Dan Langille from comment #0)

I'm OK with this change except 2 things:
- CERTS_DESC is missing.
- Please keep it sorted by putting CERTS* before COOKIE*.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-04-28 11:35:55 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c0a5bf41e8bb33e5d96a80e83bf92045f7ad8e9d

commit c0a5bf41e8bb33e5d96a80e83bf92045f7ad8e9d
Author:     Dan Langille <dvl@FreeBSD.org>
AuthorDate: 2024-04-28 11:34:06 +0000
Commit:     Dan Langille <dvl@FreeBSD.org>
CommitDate: 2024-04-28 11:34:06 +0000

    www/p5-HTTP-Tiny: allow www/p5-Mozilla-CA to be optional

    This new option is enabled by default, thus perserving existing
    behavior. There are circumstances when we don't want www/p5-Mozilla-CA
    to be installed. This patch permits that.

    PR:             278581

 www/p5-HTTP-Tiny/Makefile | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
Comment 3 Dan Langille freebsd_committer freebsd_triage 2024-04-28 11:36:43 UTC 
Thank you. This makes $WORK much easier.