Bug 278755 - devel/arduino: Use EXTRACT_AFTER_ARGS
Summary: devel/arduino: Use EXTRACT_AFTER_ARGS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Craig Leres
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-04 19:01 UTC by Daniel Engberg
Modified: 2024-05-07 00:50 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (leres)

Attachments
Patch for devel/arduino (1.24 KB, patch)
2024-05-04 19:01 UTC, Daniel Engberg 		no flags Details | Diff
Patch for arduino v2 (1.39 KB, patch)
2024-05-05 11:45 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-05-04 19:01:42 UTC 
Created attachment 250391 [details]
Patch for devel/arduino

Instead of extracting unnecessary files and then deleting just skip extracting instread to reduce I/O

Poudrire bulk OK
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-05-05 11:45:58 UTC 
Created attachment 250429 [details]
Patch for arduino v2

Be more specific about what files to remove and preserve original flags
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-05-07 00:49:06 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=760621ead617b0134ba0bc656fad29b3394c0f81

commit 760621ead617b0134ba0bc656fad29b3394c0f81
Author:     Craig Leres <leres@FreeBSD.org>
AuthorDate: 2024-05-07 00:47:41 +0000
Commit:     Craig Leres <leres@FreeBSD.org>
CommitDate: 2024-05-07 00:47:41 +0000

    devel/arduino: Use EXTRACT_AFTER_ARGS

    "Saves I/O by not extracting unused dependency"

    PR:             278755
    Reported by:    diizzy

 devel/arduino/Makefile | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)
Comment 3 Craig Leres freebsd_committer freebsd_triage 2024-05-07 00:50:04 UTC 
Thanks for the patch!