Bug 278768 - databases/mongodb60: Convert post-patch to EXTRACT_AFTER_ARGS
Summary: databases/mongodb60: Convert post-patch to EXTRACT_AFTER_ARGS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ronald Klop
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-04 20:05 UTC by Daniel Engberg
Modified: 2024-05-18 09:14 UTC (History)
0 users

See Also:
ronald: maintainer-feedback+

Attachments
Patch for mongodb60 (1.37 KB, patch)
2024-05-04 20:05 UTC, Daniel Engberg 		no flags Details | Diff
Patch for mongodb60 v2 (1.41 KB, patch)
2024-05-05 11:20 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-05-04 20:05:04 UTC 
Created attachment 250403 [details]
Patch for mongodb60

Saves I/O by not extracting bundled deps

Poduriere bulk OK
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-05-05 11:20:29 UTC 
Created attachment 250425 [details]
Patch for mongodb60 v2

Preserve default flags
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-05-18 09:08:57 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ef1c83c3421a1e33f43ece7de9a71e608b3f5048

commit ef1c83c3421a1e33f43ece7de9a71e608b3f5048
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-05-16 10:27:51 +0000
Commit:     Ronald Klop <ronald@FreeBSD.org>
CommitDate: 2024-05-18 09:07:38 +0000

    databases/mongodb60: Convert post-patch to EXTRACT_AFTER_ARGS

    Saves I/O by not extracting bundled deps

    PR:     278768

 databases/mongodb60/Makefile | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)
Comment 3 Ronald Klop freebsd_committer freebsd_triage 2024-05-18 09:14:00 UTC 
Committed. Thanks for your patch.

I'm not so fond of leaking the default value of Mk/bsd.port.mk:EXTRACT_AFTER_ARGS into my port as I now need to keep track of changes to the default. But for now it works and it saves a couple of bytes for some people. If you know of a way to just appending to EXTRACT_AFTER_ARGS I'm open for suggestions.

NB: Will get to the other similar mongodb* PRs soon.