Bug 278839 - security/sssd2: USES=samba
Summary: security/sssd2: USES=samba
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: John Hixson
URL:
Keywords:
: 276840 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-05-07 14:23 UTC by Xavier Beaudouin
Modified: 2024-08-21 18:01 UTC (History)
1 user (show)

See Also:
jhixson: maintainer-feedback+


Attachments
sssd2 patch (2.12 KB, patch)
2024-05-07 14:23 UTC, Xavier Beaudouin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xavier Beaudouin 2024-05-07 14:23:45 UTC
Created attachment 250515 [details]
sssd2 patch

Hello,

This patch motivation is to permit the dependency of sssd2 according the default values of USES=samba.

Some time we need to compile this software with samba416 or samba419, using DEFAULT_VERSION += samba=4.16 or 4.19 permit the auto adaptation of this port with correct version of samba.

Also samba 4.16 or 4.19 can depend of ldb2x OR using its own ldb which can be included on each samba version. 

Also this patch fix an old issue with python and pkg-plist.

Kind regards,
Xavier
Comment 1 Xavier Beaudouin 2024-05-07 15:24:22 UTC
I forgot to say that this port has been tested on poudriere with 13.2-p11 and 14.0-p6.

Kind regards
Comment 2 John Hixson freebsd_committer freebsd_triage 2024-05-10 18:16:46 UTC
Hi Xavier,

I am looking at and testing this today.
Comment 3 John Hixson freebsd_committer freebsd_triage 2024-05-13 20:21:46 UTC
Hi Xavier,

I've tested the patch as-is with poudriere for 13.2, 13.3, 14.0, and CURRENT. None build correctly. You may want to retest. I didn't have time to look into the issue.
Comment 4 Xavier Beaudouin 2024-05-14 07:34:28 UTC
I will looking at that today (build a "empty" poudriere without options).
Comment 5 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-05-14 13:05:12 UTC
There are a couple of problems here but the blocker seems to be that Samba does not provide the ldb headers for its bundled ldb. Those headers are required by sssd2 to build.

We are investigating now if it is possible to install the required headers with Samba. We'll send you some updates soon.
Comment 6 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-05-14 13:10:02 UTC
*** Bug 276840 has been marked as a duplicate of this bug. ***
Comment 7 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-05-16 14:20:18 UTC
(In reply to Mateusz Piotrowski from comment #5)

It looks like it is not possible without some major hacks. We'll have to provide ldb ports for all Samba ports and then switch all Samba ports to using those ldb ports instead of the bundled ldbs. This way sssd2 should continue to work in the future.
Comment 8 Xavier Beaudouin 2024-05-30 14:33:02 UTC
Will close this port. Maybe when samba416/419 when it'll will build without ldb embedded per default...
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-08-21 18:01:35 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c582a52cf7a45e1867dc6a40690e6e8539c09cb1

commit c582a52cf7a45e1867dc6a40690e6e8539c09cb1
Author:     Mateusz Piotrowski <0mp@FreeBSD.org>
AuthorDate: 2024-08-21 17:52:01 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2024-08-21 17:59:32 +0000

    security/sssd2: Use SAMBA_PORT and SAMBA_LDB_PORT

    security/sssd2 can depend on any Samba version we have in the ports
    tree. However, having the exact version of Samba hardcoded in *_DEPENDS
    variables makes it hard to use a non-default Samba version.

    Let the port pick up the default Samba version (and its ldb port) via
    samba.mk. Since net/samba416 is still the default, nothing really
    changes for sssd2. However, users can now build sssd2 against
    net/samba419 if they set DEFAULT_VERSIONS=samba=4.19.

    PR:                     278839 280774
    Approved by:            portmgr (infrastructure)
    Sponsored by:           Klara, Inc.
    Co-authored-by:         Xavier Beaudouin <kiwi@oav.net>

 security/sssd2/Makefile | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)