Bug 278885 - [exp-run] Mk/bsd.default-versions.mk: Update to PostgreSQL 16
Summary: [exp-run] Mk/bsd.default-versions.mk: Update to PostgreSQL 16
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: pgsql
URL:
Keywords:
Depends on: 279189 279190 279191 279192 279193 279194
Blocks:
  Show dependency treegraph
 
Reported: 2024-05-10 00:59 UTC by Kevin Bowling
Modified: 2024-07-23 16:34 UTC (History)
3 users (show)

See Also:
kbowling: maintainer-feedback-
antoine: exp-run+


Attachments
pgsql 16 (6.53 KB, patch)
2024-05-10 00:59 UTC, Kevin Bowling
no flags Details | Diff
pgsql + pgaudit 16 (8.25 KB, patch)
2024-06-14 17:24 UTC, Kevin Bowling
no flags Details | Diff
pgsql + pgaudit 16 (8.24 KB, patch)
2024-07-13 20:44 UTC, Kevin Bowling
kbowling: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Bowling freebsd_committer freebsd_triage 2024-05-10 00:59:39 UTC
Created attachment 250562 [details]
pgsql 16

It's now at the third patch level, let's see what breaks and contemplate a default upgrade.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-05-12 07:57:12 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b17bdbf17c4acf3efaa9dd5c58b7881d151cb7d4

commit b17bdbf17c4acf3efaa9dd5c58b7881d151cb7d4
Author:     Kevin Bowling <kbowling@FreeBSD.org>
AuthorDate: 2024-05-12 07:53:47 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2024-05-12 07:56:06 +0000

    databases/postgresql-promscale: Limit to pgsql < 16

    Promscale is no longer developed so it is unlikely to get 16 support

    PR:             278885
    Reported by:    exp-run (antoine)

 databases/postgresql-promscale/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-05-12 08:06:16 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5c969afad5e56473adfa664dcdef4aab291639f8

commit 5c969afad5e56473adfa664dcdef4aab291639f8
Author:     Kevin Bowling <kbowling@FreeBSD.org>
AuthorDate: 2024-05-12 08:04:55 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2024-05-12 08:04:55 +0000

    databases/postgis31: Limit to pgsql < 15 per documentation

    https://postgis.net/2023/05/PostGIS-3.3.3-3.2.5-3.1.9-3.0.9-Patch-Releases/

    PR:             278885
    Reported by:    exp-run (antoine)

 databases/postgis31/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-05-12 08:08:19 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=78e9101ec23dee3bfdb280fb66e41f372993d837

commit 78e9101ec23dee3bfdb280fb66e41f372993d837
Author:     Kevin Bowling <kbowling@FreeBSD.org>
AuthorDate: 2024-05-12 08:06:28 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2024-05-12 08:07:40 +0000

    databases/postgis32: Limit to pgsql < 16 per documentation

    https://postgis.net/2023/05/PostGIS-3.3.3-3.2.5-3.1.9-3.0.9-Patch-Releases/

    PR:             278885
    Reported by:    exp-run (antoine)

 databases/postgis32/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-05-21 06:51:39 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c1a1bc6d296b8a602ae1d9cdc7b7896a93c93562

commit c1a1bc6d296b8a602ae1d9cdc7b7896a93c93562
Author:     Kevin Bowling <kbowling@FreeBSD.org>
AuthorDate: 2024-05-21 06:49:50 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2024-05-21 06:49:50 +0000

    databases/pg_similarity: Limit to pgsql < 16

    This extension seems unmaintained.  It can be patched easily for pgsql
    16 but should be updated first.

    PR:             278885

 databases/pg_similarity/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 7 Kevin Bowling freebsd_committer freebsd_triage 2024-05-21 07:15:01 UTC
(In reply to Antoine Brodin from comment #6)
Seems like an error in the framework or a dep somehow?

"pkg-static: postgresql15-client-15.7 conflicts with postgresql12-client-12.19 (installs files into the same place)."

It's not supposed to work with the current default version, 15.
Comment 8 Antoine Brodin freebsd_committer freebsd_triage 2024-05-21 07:22:09 UTC
(In reply to Kevin Bowling from comment #7)
or a bug in the way you use the framework
Comment 9 Kevin Bowling freebsd_committer freebsd_triage 2024-05-21 21:07:16 UTC
(In reply to Antoine Brodin from comment #8)
Please enlighten us.
Comment 10 Antoine Brodin freebsd_committer freebsd_triage 2024-05-21 22:00:24 UTC
(In reply to Kevin Bowling from comment #7)

In this case, you have to use something like
.if blablasqlversion > something
IGNORE= doesn't work with this version
.endif

The default versions stuff can't work with it.
Comment 11 Kevin Bowling freebsd_committer freebsd_triage 2024-05-25 05:48:14 UTC
(In reply to Antoine Brodin from comment #10)
Can you confirm if this is what you mean https://reviews.freebsd.org/D45359
Comment 12 commit-hook freebsd_committer freebsd_triage 2024-05-25 07:21:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5e7078e10186aeeac0693b01c182c1b16b0d1e1d

commit 5e7078e10186aeeac0693b01c182c1b16b0d1e1d
Author:     Kevin Bowling <kbowling@FreeBSD.org>
AuthorDate: 2024-05-25 07:18:29 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2024-05-25 07:21:03 +0000

    databases/postgis31: enforce pgsql version limit

    PR:             278885
    Reviewed by:    antoine
    Fixes:  5c969afad5e5 databases/postgis31: Limit to pgsql < 15 per documentation
    Differential Revision:  https://reviews.freebsd.org/D45359

 databases/postgis31/Makefile | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Comment 13 Kevin Bowling freebsd_committer freebsd_triage 2024-06-14 17:24:55 UTC
Created attachment 251454 [details]
pgsql + pgaudit 16
Comment 14 Kevin Bowling freebsd_committer freebsd_triage 2024-06-14 17:26:11 UTC
(In reply to Antoine Brodin from comment #1)
Hi Antoine,

Would you be able to run another exp-run?  I have refreshed the patch and it is expected that all fallout have been addressed in main and this new patch.
Comment 16 commit-hook freebsd_committer freebsd_triage 2024-07-06 23:41:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ad6088a3ab523dff0045e62671250c7dd0227a45

commit ad6088a3ab523dff0045e62671250c7dd0227a45
Author:     Kevin Bowling <kbowling@FreeBSD.org>
AuthorDate: 2024-07-06 23:22:21 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2024-07-06 23:22:21 +0000

    databases/postgresql-promscale: enforce pgsql version limit

    PR:             278885
    Reported by:    antoine

 databases/postgresql-promscale/Makefile | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
Comment 17 commit-hook freebsd_committer freebsd_triage 2024-07-06 23:41:27 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4d011bdbc64aecb5d158822b01a1d242cb865fa6

commit 4d011bdbc64aecb5d158822b01a1d242cb865fa6
Author:     Kevin Bowling <kbowling@FreeBSD.org>
AuthorDate: 2024-07-06 23:21:13 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2024-07-06 23:21:13 +0000

    databases/postgis32: enforce pgsql version limit

    PR:             278885
    Reported by:    antoine

 databases/postgis32/Makefile | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Comment 18 Kevin Bowling freebsd_committer freebsd_triage 2024-07-06 23:42:06 UTC
(In reply to Antoine Brodin from comment #15)
Thank you.  I applied the same method you showed me earlier and think we should be clear of all build regressions now.
Comment 19 Antoine Brodin freebsd_committer freebsd_triage 2024-07-13 09:16:53 UTC
(In reply to Kevin Bowling from comment #18)

The patch fails to apply
Comment 20 Kevin Bowling freebsd_committer freebsd_triage 2024-07-13 20:44:42 UTC
Created attachment 252024 [details]
pgsql + pgaudit 16

Rebase on main
Comment 21 Antoine Brodin freebsd_committer freebsd_triage 2024-07-16 07:51:00 UTC
Exp-run looks fine
Comment 22 Kevin Bowling freebsd_committer freebsd_triage 2024-07-16 18:06:25 UTC
I would like to commit this in a week or so unless anyone has other ideas.
Comment 23 commit-hook freebsd_committer freebsd_triage 2024-07-23 16:32:33 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b86336fa4d39af5eb0a1f228a649ca4389e628dc

commit b86336fa4d39af5eb0a1f228a649ca4389e628dc
Author:     Kevin Bowling <kbowling@FreeBSD.org>
AuthorDate: 2024-07-23 16:29:21 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2024-07-23 16:31:07 +0000

    Mk/bsd.default-versions.mk: Update to PostgreSQL 16

    See UPDATING for upgrade advice

    PR:             278885
    Exp-run by:     antoine

 Mk/bsd.default-versions.mk |  2 +-
 UPDATING                   | 53 ++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 54 insertions(+), 1 deletion(-)