Bug 278901 - irc/znc: include pkgconfig at runtime for module compiling
Summary: irc/znc: include pkgconfig at runtime for module compiling
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dan Langille
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-10 20:34 UTC by Dan Langille
Modified: 2024-05-10 21:15 UTC (History)
1 user (show)

See Also:
dbaio: maintainer-feedback+

Attachments
alters USES=pkgconfig to USES=pkgconfig:both (573 bytes, patch)
2024-05-10 20:34 UTC, Dan Langille 		dbaio: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Langille freebsd_committer freebsd_triage 2024-05-10 20:34:38 UTC 
Created attachment 250573 [details]
alters USES=pkgconfig to USES=pkgconfig:both

After updating to 1.9.0, I needed to recompile some modules:

Checking for list of available modules... 
Opening config [/usr/home/dvl/.znc/configs/znc.conf]... 
Found old config from ZNC 1.8.2. Saving a backup of it.
Creating a config backup... /usr/home/dvl/.znc/configs/znc.conf.pre-1.9.0
Loading global module [webadmin]... 
Loading global module [adminlog]... 
Loading global module [playback]... [ Version mismatch for module playback: core is 1.9.0, module is built for 1.8.2. Recompile this module. ]
Unrecoverable config error.

Attempts to recompile resulted in:

Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE)

The attached patch fixed that for me
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-05-10 21:14:32 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=182dd49cd63d8cad14e7625db663d61d864a1c7c

commit 182dd49cd63d8cad14e7625db663d61d864a1c7c
Author:     Dan Langille <dvl@FreeBSD.org>
AuthorDate: 2024-05-10 21:10:34 +0000
Commit:     Dan Langille <dvl@FreeBSD.org>
CommitDate: 2024-05-10 21:13:31 +0000

    irc/znc: add pkgconfig at runtime

    Include pkgconfig at runtime for module compiling

    PR:             278901

 irc/znc/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 2 Dan Langille freebsd_committer freebsd_triage 2024-05-10 21:15:05 UTC 
Thank you.