Bug 278906 - net/libngtcp2: Update to 1.4.0
Summary: net/libngtcp2: Update to 1.4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL: https://github.com/ngtcp2/ngtcp2/rele...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-11 05:54 UTC by Daniel Engberg
Modified: 2024-05-28 10:26 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Patch for libngtcp2 (2.19 KB, patch)
2024-05-11 05:54 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-05-11 05:54:01 UTC 
Created attachment 250579 [details]
Patch for libngtcp2

* Switch to CMake for faster builds
* Remove C++ requirements, we don't build anything that's written in C++
* Disable OpenSSL requirement as it fails due to lack of QUIC support which is in 3.2
* Rearrange Makefile to follow Porters Handbook more closely and for readability
* Enable "make test"

Compile and runtime tested on FreeBSD 13.2-RELEASE (amd64) (make, make check-plist, make test)
Poudriere testport OK 13.2-RELEASE (amd64)
Poudriere testport OK 14.0-RELEASE (amd64)
Comment 1 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-05-23 01:59:37 UTC 
Updated to 1.4.0 and 1.5.0 in ports c5910ae77b5dbe745fbfc0e50715d31694516adc and ports c5910ae77b5dbe745fbfc0e50715d31694516adc. I'll remove C++ setting in an upcoming commit.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-05-28 10:25:15 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a96f2c67df5a3427a85aac9bffeaedb0971a7ad7

commit a96f2c67df5a3427a85aac9bffeaedb0971a7ad7
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2024-05-28 10:02:47 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2024-05-28 10:21:55 +0000

    net/libngtcp2: Remove USES=compiler:c++14-lang

    PR:             278906
    Reported by:    diizzy

 net/libngtcp2/Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-05-28 10:26:36 UTC 
Committed. Thanks!