Bug 278925 - japanese/font-bizud-mincho: Improve port
Summary: japanese/font-bizud-mincho: Improve port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-11 23:06 UTC by Daniel Engberg
Modified: 2024-05-14 18:01 UTC (History)
1 user (show)

See Also:
mew14930xvi: maintainer-feedback+


Attachments
Patch for font-bizud-mincho (2.53 KB, patch)
2024-05-11 23:06 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-05-11 23:06:01 UTC
Created attachment 250592 [details]
Patch for font-bizud-mincho

- Use upstream release archive (reduces distfile with ~20Mbyte)
- Only extract what we really need (reduces I/O)
- Remove DOCS option
Comment 1 mew14930xvi 2024-05-12 02:16:46 UTC
No source files.
No license file.
No documentation.
Not accepted.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-05-12 04:58:57 UTC
Source files?
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github
This will be enforced

License file is optional (see Porters Handbook)

It's a font, there's no documentation needed

We're shaving off roughly 100Mbyte in I/O per exection by doing this and it's already applied to other fonts related ports that have similar issues.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-05-14 17:50:18 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=652622ae4f9d98c6c1300245b57861343d6a8a40

commit 652622ae4f9d98c6c1300245b57861343d6a8a40
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-05-14 17:47:35 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-05-14 17:47:49 +0000

    japanese/font-bizud-mincho: Improve and simplify port

    - Use upstream release archive
    - Extract minimum amount of files required (reduces I/O)
    - Remove DOCS option

    PR:             278925
    Reviewed by:     mew14930xvi <mew14930xvi@inbox.lv> (maintainer)

 japanese/font-bizud-mincho/Makefile | 28 +++++++++++++---------------
 japanese/font-bizud-mincho/distinfo |  6 +++---
 2 files changed, 16 insertions(+), 18 deletions(-)
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2024-05-14 17:50:38 UTC
Committed, thanks!
Comment 5 mew14930xvi 2024-05-14 17:57:19 UTC
Sorry, I just became the maintainer and did not intend to approve it.
Please revert or remove me from the maintainer.
Comment 6 mew14930xvi 2024-05-14 18:01:10 UTC
My mistake.
Thank you for your time.