Bug 278938 - games/veloren-weekly: Fix build with rust 1.78.0
Summary: games/veloren-weekly: Fix build with rust 1.78.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL: https://pkg-status.freebsd.org/beefy1...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-12 17:09 UTC by Mikael Urankar
Modified: 2024-05-18 15:51 UTC (History)
0 users

See Also:
jbeich: maintainer-feedback+

Attachments
v0 (3.06 KB, patch)
2024-05-12 17:09 UTC, Mikael Urankar 		no flags Details | Diff
v0 (19.93 KB, patch)
2024-05-16 11:47 UTC, Mikael Urankar 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer freebsd_triage 2024-05-12 17:09:45 UTC 
Created attachment 250600 [details]
v0

Just to let you know that veloren is broken with rust 1.78.0. The only way I found to fix it, until upstream catch up with rust 1.78, is to disable simd. See attached patch.
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-05-13 11:04:34 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b352c01459d9b6243eeeb7443bb632ce7fca943e

commit b352c01459d9b6243eeeb7443bb632ce7fca943e
Author:     Mikael Urankar <mikael@FreeBSD.org>
AuthorDate: 2024-05-12 17:05:27 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2024-05-13 11:03:24 +0000

    games/veloren-weekly: Fix build with rust 1.78.0

    PR:             278834, 278938
    Approved by:    portmgr (build fix blanket)

 games/veloren-weekly/files/patch-rust-1.78.0 (new)   | 20 ++++++++++++++++++++
 .../files/patch-rust-1.78.0-disable-simd (new)       | 16 ++++++++++++++++
 2 files changed, 36 insertions(+)
Comment 2 Mikael Urankar freebsd_committer freebsd_triage 2024-05-16 11:47:58 UTC 
Created attachment 250697 [details]
v0

Hmm, sorry. I thought the patch I've committed were enough.
I'm testing the attached patch
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-05-17 21:28:26 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=145551c111f728458eb486bfa04afb8c68841f52

commit 145551c111f728458eb486bfa04afb8c68841f52
Author:     Mikael Urankar <mikael@FreeBSD.org>
AuthorDate: 2024-05-16 11:45:54 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2024-05-17 21:25:26 +0000

    games/veloren-weekly: Add missing rust 1.78.0 fix after b352c01459d9

    PR:             278938
    Reported by:    pkg-fallout

 .../files/patch-rust-1.78.0-vek (new)              | 416 +++++++++++++++++++++
 1 file changed, 416 insertions(+)
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-05-18 15:50:15 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4ec0307c1551f9c26b3c65dddb583464c4e081a3

commit 4ec0307c1551f9c26b3c65dddb583464c4e081a3
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2024-05-18 11:26:23 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2024-05-18 15:46:54 +0000

    games/veloren-weekly: restore SIMD via upstream after b352c01459d9

    PR:             278938

 games/veloren-weekly/Makefile                      |   1 +
 games/veloren-weekly/Makefile.crates               |  10 +-
 games/veloren-weekly/distinfo                      |  20 +-
 .../veloren-weekly/files/patch-rust-1.75.0 (gone)  |  28 -
 games/veloren-weekly/files/patch-rust-1.78.0       | 668 ++++++++++++++++++++-
 .../files/patch-rust-1.78.0-disable-simd (gone)    |  16 -
 .../files/patch-rust-1.78.0-vek (gone)             | 416 -------------
 games/veloren-weekly/files/patch-vek               |  23 +-
 8 files changed, 675 insertions(+), 507 deletions(-)