Bug 278989 - [PATCH] mail/thunderbird: fix build with clang 18
Summary: [PATCH] mail/thunderbird: fix build with clang 18
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Christoph Moench-Tegeder
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-14 20:51 UTC by Jung-uk Kim
Modified: 2024-05-15 20:19 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (gecko)

Attachments
Fix build with clang 18 (7.03 KB, application/mbox)
2024-05-14 20:51 UTC, Jung-uk Kim 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jung-uk Kim freebsd_committer freebsd_triage 2024-05-14 20:51:37 UTC 
Created attachment 250658 [details]
Fix build with clang 18

The attached patch fixed build with clang 18 for me.  FYI, I've originally taken this from PLD Linux Distribution:

https://github.com/pld-linux/thunderbird/commit/1b415245f46e2d8667ee0448bfeb1ff3a0ad67ee

In turn, it was based on the following:

https://github.com/rust-lang/rust-bindgen/pull/2689
https://phabricator.services.mozilla.com/D197012
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-05-15 20:14:32 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0f1e62d922cb5892cd2684275101fe05e011371b

commit 0f1e62d922cb5892cd2684275101fe05e011371b
Author:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
AuthorDate: 2024-05-15 20:13:22 +0000
Commit:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
CommitDate: 2024-05-15 20:13:22 +0000

    mail/thunderbird: fix build with clan18

    Sumbitted by:   jkim
    PR:                             278989

 mail/thunderbird/files/patch-llvm18 (new) | 199 ++++++++++++++++++++++++++++++
 1 file changed, 199 insertions(+)
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-05-15 20:15:33 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3c6cc9a9508c7b947bf9ed5d08e48056729c2b69

commit 3c6cc9a9508c7b947bf9ed5d08e48056729c2b69
Author:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
AuthorDate: 2024-05-15 20:14:29 +0000
Commit:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
CommitDate: 2024-05-15 20:14:29 +0000

    www/firefox-esr: fix build with clang18

    Submitted by:   jkim
    PR:                             278989

 www/firefox-esr/files/patch-llvm18 (new) | 199 +++++++++++++++++++++++++++++++
 1 file changed, 199 insertions(+)
Comment 3 Christoph Moench-Tegeder freebsd_committer freebsd_triage 2024-05-15 20:19:49 UTC 
I had hoped that nobody would rock the boat for the last few weeks before ESR switches up (128 will be the next ESR), but here we go (and let's fix it for both ports).
Thanks anyways :)