Bug 279001 - editors/helix: strip binary and pet portlint
Summary: editors/helix: strip binary and pet portlint
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ashish SHUKLA
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-15 08:53 UTC by Ralf van der Enden
Modified: 2024-05-15 14:37 UTC (History)
0 users

See Also:
ashish: maintainer-feedback+

Attachments
strip hx binary and pet portlint (1.99 KB, patch)
2024-05-15 08:55 UTC, Ralf van der Enden 		tremere: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf van der Enden 2024-05-15 08:53:26 UTC 

    


    


      



        
          Comment 1
        

        
          Ralf van der Enden

        

        
        

        
          2024-05-15 08:55:36 UTC
        

      






Created attachment 250672 [details]
strip hx binary and pet portlint

Not sure if a PORTREVISION bump is necessary, since this doesn't affect the functionality of the binary

    


    


      



        
          Comment 2
        

        
          commit-hook

        

        
            freebsd_committer
            freebsd_triage
        

        
          2024-05-15 14:33:48 UTC
        

      






A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2fd12e8627ca4e4cb86ec3d4ea1da179b445071c

commit 2fd12e8627ca4e4cb86ec3d4ea1da179b445071c
Author:     Ralf van der Enden <tremere@cainites.net>
AuthorDate: 2023-10-11 13:04:32 +0000
Commit:     Ashish SHUKLA <ashish@FreeBSD.org>
CommitDate: 2024-05-15 14:31:52 +0000

    editors/helix: strip binary and pet portlint

    PR:             279001

 editors/helix/Makefile | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

    


    


      



        
          Comment 3
        

        
          Ashish SHUKLA

        

        
            freebsd_committer
            freebsd_triage
        

        
          2024-05-15 14:37:27 UTC
        

      






We need to bump PORTREVISION, if there is change in output package (in this case stripping).

Thanks, committed.