Bug 279009 - mail/bsfilter: Update to recent version for ruby 3.3
Summary: mail/bsfilter: Update to recent version for ruby 3.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Zsolt Udvari
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-15 13:04 UTC by Yoshihiro Takahashi
Modified: 2024-07-21 18:21 UTC (History)
2 users (show)

See Also:

Attachments
Update to recent version (180.65 KB, patch)
2024-05-15 13:04 UTC, Yoshihiro Takahashi 		no flags Details | Diff
Update to recent version patch as of 20240721 (181.61 KB, patch)
2024-07-21 06:20 UTC, Yoshihiro Takahashi 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yoshihiro Takahashi freebsd_committer freebsd_triage 2024-05-15 13:04:31 UTC 
Created attachment 250679 [details]
Update to recent version

Add a patch to update to recent version for ruby 3.3 from upstream repository.
Comment 1 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-14 18:38:25 UTC 
Hi Yoshihiro,
do you want take maintainership?
Comment 2 Yoshihiro Takahashi freebsd_committer freebsd_triage 2024-07-15 03:39:20 UTC 
Yes, please change it to me.
Comment 3 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-15 05:28:18 UTC 
Where did the patch come from? Or did you make it?
Comment 4 Yoshihiro Takahashi freebsd_committer freebsd_triage 2024-07-15 09:41:59 UTC 
The newest code is the following.
https://osdn.net/cvs/view/bsfilter/
Comment 5 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-15 16:38:59 UTC 
(In reply to Yoshihiro Takahashi from comment #4)
Maybe would be better the fetch the whole file instead of patching.
Comment 6 Yoshihiro Takahashi freebsd_committer freebsd_triage 2024-07-20 05:10:56 UTC 
(In reply to Zsolt Udvari from comment #5)
I tried to use the whole file, but there are some problems.
- There is no official tarball for the latest release because it's an unnamed release.
- When I fetch the tarball via CVS repository several times, the checksum is different
  every time.
Comment 7 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-20 18:22:54 UTC 
(In reply to Yoshihiro Takahashi from comment #6)
Ah, the server is very fast :(
I think it's good in this case.
Comment 8 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-20 18:33:28 UTC 
Because we don't support ruby 2.* can remove "if RUBY_VER:M3*" test from Makefile and add rubygem-sdbm to RUN_DEPENDS above. And can remove all "include" and it's enough "include <bsd.port.mk>" to the end of Makefile.
Comment 9 Yoshihiro Takahashi freebsd_committer freebsd_triage 2024-07-21 06:20:45 UTC 
Created attachment 252199 [details]
Update to recent version patch as of 20240721

Thank you for your review.
I've updated my patch.
Comment 10 commit-hook freebsd_committer freebsd_triage 2024-07-21 18:21:08 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=089d73ae02c2650bf4a1f06148eba39eb6c63788

commit 089d73ae02c2650bf4a1f06148eba39eb6c63788
Author:     Yoshihiro Takahashi <nyan@FreeBSD.org>
AuthorDate: 2024-07-21 18:09:08 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2024-07-21 18:19:43 +0000

    mail/bsfilter: update to recent version for ruby 3.3

    Clean Makefile
    Update WWW.
    Submitter takes maintainership.

    PR:             279009
    Obtained from:  https://osdn.net/cvs/view/bsfilter/bsfilter/bsfilter?revision=1.89&view=markup

 mail/bsfilter/Makefile                            |   19 +-
 mail/bsfilter/files/patch-bsfilter_bsfilter (new) | 5075 +++++++++++++++++++++
 2 files changed, 5082 insertions(+), 12 deletions(-)
Comment 11 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-21 18:21:42 UTC 
Committed, thanks!