Bug 279059 - x11-toolkits/girara: add LICENSE
Summary: x11-toolkits/girara: add LICENSE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Guido Falsi
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2024-05-17 18:22 UTC by Chris Hutchinson
Modified: 2024-05-22 16:05 UTC (History)
1 user (show)

See Also:
madpilot: maintainer-feedback+

Attachments
git diff against x11-toolkits/girara (661 bytes, patch)
2024-05-17 18:22 UTC, Chris Hutchinson 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2024-05-17 18:22:17 UTC 
Created attachment 250726 [details]
git diff against x11-toolkits/girara

add (missing) LICENSE to x11-toolkits/girara
Comment 1 mew14930xvi 2024-05-17 18:41:03 UTC 
It is Zlib, not BSD2CLAUSE.
https://github.com/pwmt/girarar
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2024-05-17 19:59:13 UTC 
(In reply to mew14930xvi from comment #1)

Hi,

Thanks for the patch to the submitter.

Looks like you're right, it is reported as ZLib by upstream and github.

I'll look at this in the weekend.
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2024-05-17 20:00:11 UTC 
BTW I think bumping PORTREVISION to add LICENSE is overkill.

I'll avoid that in the commit.
Comment 4 Chris Hutchinson 2024-05-17 22:45:18 UTC 
> BTW I think bumping PORTREVISION to add LICENSE is overkill.
Gah! I only just saw your comment here. I just made some 75 LICENSE
related submissions (all with a revision bump).
You're probably right. I'll refrain from that in the future. :)

--Chris
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-05-21 16:14:58 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=793672c0df221077d5267ebac57c6488e80d8623

commit 793672c0df221077d5267ebac57c6488e80d8623
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2024-05-21 16:13:12 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2024-05-21 16:13:12 +0000

    x11-toolkits/girara: Add LICENSE

    PR:             279059

 x11-toolkits/girara/Makefile | 3 +++
 1 file changed, 3 insertions(+)
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2024-05-22 16:05:24 UTC 
LICENSE added.

Thanks!