Bug 279106 - x11-wm/bbpager: add LICENSE
Summary: x11-wm/bbpager: add LICENSE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Zsolt Udvari
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2024-05-17 21:57 UTC by Chris Hutchinson
Modified: 2024-07-10 21:40 UTC (History)
2 users (show)

See Also:
A.J.Caines: maintainer-feedback+
A.J.Caines: maintainer-feedback+

Attachments
git diff against x11-wm/bbpager (584 bytes, patch)
2024-05-17 21:57 UTC, Chris Hutchinson 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2024-05-17 21:57:04 UTC 
Created attachment 250771 [details]
git diff against x11-wm/bbpager

Add (missing) LICENSE for x11-wm/bbpager
Comment 1 Andrew J. Caines 2024-05-17 22:16:26 UTC 
Approved. Thank you, Chris.
Comment 2 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-01 09:53:16 UTC 
If the LICENSE_FILE contains COPYING you don't need install with DOCS.

Error: /usr/local/bin/bbpager is linked to /usr/local/lib/libXft.so.2 from x11-fonts/libXft but it is not declared as a dependency
Warning: you need USE_XORG+=xft
Error: /usr/local/bin/bbpager is linked to /usr/local/lib/libICE.so.6 from x11/libICE but it is not declared as a dependency
Warning: you need USE_XORG+=ice

The DOCS: NEWS file is empty, INSTALL is a description about ./configure. I think can remove from DOCS.

Please check suggestions of portlint, portclippy and portfmt!
Comment 3 Andrew J. Caines 2024-07-01 18:23:13 UTC 
(In reply to Zsolt Udvari from comment #2)

Thanks for reporting this. I approve adding USE_XORG and removing DOCS.
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-07-10 17:42:11 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f5bd252c2016873d04349b7fcd1b6885123fbafe

commit f5bd252c2016873d04349b7fcd1b6885123fbafe
Author:     Chris Hutchinson <portmaster@bsdforge.com>
AuthorDate: 2024-07-10 17:36:19 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2024-07-10 17:36:19 +0000

    x11-wm/bbpager: add LICENSE

    License is GPLv2 and add LICENSE_FILE (COPYING).
    Add ice and xft to USE_XORG.
    Remove COPYING from DOCS.
    Remove empty NEWS and INSTALL from DOCS.
    Pet portlint and portfmt.

    PR:             279106
    Approved by:    Andrew J. Caines <A.J.Caines@halplant.com> (maintainer)

 x11-wm/bbpager/Makefile  | 16 +++++++++-------
 x11-wm/bbpager/pkg-plist |  3 ---
 2 files changed, 9 insertions(+), 10 deletions(-)
Comment 5 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-10 17:42:31 UTC 
Committed, thanks!
Comment 6 Andrew J. Caines 2024-07-10 21:40:05 UTC 
Thank you, Chris and Zsolt.