Created attachment 250776 [details] git diff against x11-wm/piewm Add (missing) LICENSE for x11-wm/piewm
I have no objection to adding a LICENSE to x11-wm/piewm. That said, it is not obvious to me that the MIT license is appropriate; indeed, it's not obvious to me what license would be appropriate. Scanning through the files in the distribution, I find each of the following at least once: * Copyright (C) 1989 by Don Hopkins. All rights reserved. * Copyright 1989 Massachusetts Institute of Technology * copyright message is preserved. There is no warranty, and no author * copyright notice and this permission notice appear in supporting * Portions Copyright 1991 by the University of Maryland * that the above copyright notice appear in all copies and that both that .SH COPYRIGHT /* Copyright 1987, Massachusetts Institute of Technology */ /** Copyright 1990 by Solbourne Computer Inc. **/ /** Copyright 1988 by Evans & Sutherland Computer Corporation, **/ /** copies and that both that copyright notice and this permis- **/ /** granted, provided that the above copyright notice appear in all **/ /** Portions Copyright 1989 by the Massachusetts Institute of Technology **/ copyright 1989 Hewlett-Packard Company and the Massachusetts Institute of Portions copyright 1988 Evans & Sutherland Computer Corporation; portions (Obtained from within the unpacked distribution files & running: grep -hwi copyright * | sort -u Which is quite crude... but illustrative.) For comparison, I also see: grep -hwi license * | sort -u produces no output.
(In reply to david from comment #1) FWIW I unpacked the source and examined all the source to determine what license prevailed, or whether a multi-license applied. MIT appeared to be prevail as IP holder. But it's your port, so it's your decision. I'm just trying to help. :-) --Chris
I appreciate the help -- but I am quite at a loss as to "what makes sense" in this situation. If anyone has a (pointer to a) relevant clue, I'd appreciate the reference. (I am concerned that placing an incorrect LICENSE on a port may actually do more harm than good. But then, I am largely ignorant of the technical aspects of such things.)
Technically speaking, piewm appears to use multiple licenses, but they are all minor variations of the MIT license, so they belong to the "MIT/X11 license" family. The main difference is that some of them include a "No Endorsement" clause. However, it is still appropriate to classify them under the "MIT/X11 license" group, and "MIT" seems to be the correct name for this category. The distfiles contains 34 sources files, and they all have a Copyright: $ ls *.[ch] | wc -l 34 $ grep 'Copyright' * | cut -d ':' -f 1 | uniq | wc -l 34 And all their multiple copyright match the "MIT" group: $ grep 'Copyright' * LocPixmap.c: * Copyright 1989 Massachusetts Institute of Technology LocPixmap.c: * Portions Copyright 1991 by the University of Maryland add_window.c:/** Copyright 1988 by Evans & Sutherland Computer Corporation, **/ add_window.c:/** Portions Copyright 1989 by the Massachusetts Institute of Technology **/ add_window.h:/** Copyright 1988 by Evans & Sutherland Computer Corporation, **/ add_window.h:/** Portions Copyright 1989 by the Massachusetts Institute of Technology **/ cursor.c: * Copyright 1989 Massachusetts Institute of Technology events.c:/** Copyright 1988 by Evans & Sutherland Computer Corporation, **/ events.c:/** Portions Copyright 1989 by the Massachusetts Institute of Technology **/ events.h:/** Copyright 1988 by Evans & Sutherland Computer Corporation, **/ events.h:/** Portions Copyright 1989 by the Massachusetts Institute of Technology **/ gc.c:/** Copyright 1988 by Evans & Sutherland Computer Corporation, **/ gc.c:/** Portions Copyright 1989 by the Massachusetts Institute of Technology **/ gc.h:/** Copyright 1988 by Evans & Sutherland Computer Corporation, **/ gc.h:/** Portions Copyright 1989 by the Massachusetts Institute of Technology **/ gram.y:/** Copyright 1988 by Evans & Sutherland Computer Corporation, **/ gram.y:/** Portions Copyright 1989 by the Massachusetts Institute of Technology **/ iconmgr.c: * Copyright 1989 Massachusetts Institute of Technology iconmgr.h: * Copyright 1989 Massachusetts Institute of Technology icons.c: * Copyright 1989 Massachusetts Institute of Technology icons.h: * Copyright 1989 Massachusetts Institute of Technology lex.l:/** Copyright 1988 by Evans & Sutherland Computer Corporation, **/ lex.l:/** Portions Copyright 1989 by the Massachusetts Institute of Technology **/ list.c:/** Copyright 1988 by Evans & Sutherland Computer Corporation, **/ list.c:/** Portions Copyright 1989 by the Massachusetts Institute of Technology **/
(In reply to Olivier Cochard from comment #4) Thanks, Olivier; I appreciate you taking the time to look into the issue and provide somoe guidance. I am happy to accept your suggestion/recommendation.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8a7be43a9d886ec1c082d48affc0c717fbffbd94 commit 8a7be43a9d886ec1c082d48affc0c717fbffbd94 Author: Olivier Cochard <olivier@FreeBSD.org> AuthorDate: 2025-04-02 17:13:11 +0000 Commit: Olivier Cochard <olivier@FreeBSD.org> CommitDate: 2025-04-02 17:20:46 +0000 x11-wm/piewm: add LICENSE The code contains multiple licenses, but they all belong to the MIT/X11 family. PR: 279111 Reported by: Chris Hutchinson Approved by: david@catwhisker.org (maintainer) x11-wm/piewm/Makefile | 2 ++ 1 file changed, 2 insertions(+)
Thanks for your contribution! Committed with a small change: There is no need to update the PORTREVISION for this change, because we don’t need to rebuild the package (cf. chapter '5.2.3.1. PORTREVISION' from the Porter's Handbook).