Bug 279196 - security/pks: upgrade BDB to 18 and remove DEPRECIATED
Summary: security/pks: upgrade BDB to 18 and remove DEPRECIATED
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Rene Ladan
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2024-05-21 08:45 UTC by Chris Hutchinson
Modified: 2024-07-07 17:06 UTC (History)
2 users (show)

See Also:
tphilipp: maintainer-feedback+


Attachments
git diff against security/pks (2.69 KB, patch)
2024-05-21 08:45 UTC, Chris Hutchinson
no flags Details | Diff
git diff against security/pks (2.79 KB, patch)
2024-05-21 09:00 UTC, Chris Hutchinson
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2024-05-21 08:45:41 UTC
Created attachment 250848 [details]
git diff against security/pks

I need something like this, and took a stab at sks,
but fixing it was more work than I wanted to invest.
So I took this. :)
The git diff attached to this pr(1) upgrades BDB to 18.
While here, improve Makefile and fix 2 patch files. Lastly,
remove DEPRECIATION notice.

Files affected:
Makefile
files/patch-kd_generic.c
files/patch-mkpksdconf.in

That's it.

--Chris
Comment 1 Chris Hutchinson 2024-05-21 09:00:50 UTC
Created attachment 250849 [details]
git diff against security/pks

OK I performed a search before working on this
and there were no reported pr's. Now I find a pr
where the MAINTAINER signed off on dropping this
port. So this patch includes everything already
mentioned for the original patch. But with the
inclusion of me as MAINTAINER.

That's it.

All tests return OK.

--Chris
Comment 2 Tassilo Philipp 2024-05-21 09:41:09 UTC
I'm totally ok with Chris taking over maintainership, and keeping this port (with his patches).
Thanks!
Comment 3 Rene Ladan freebsd_committer freebsd_triage 2024-07-07 17:05:38 UTC
Patch committed, thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-07-07 17:06:12 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e6df69f8687330d0842e549c0dd79dbd3ffb4f21

commit e6df69f8687330d0842e549c0dd79dbd3ffb4f21
Author:     Chris Hutchinson <portmaster@bsdforge.com>
AuthorDate: 2024-07-07 17:03:02 +0000
Commit:     Rene Ladan <rene@FreeBSD.org>
CommitDate: 2024-07-07 17:04:57 +0000

    security/pks: undeprecate, switch to db18

    Submitter becomes new maintainer
    PR:             279196
    Approved by:    previous maintainer

 security/pks/Makefile                  | 25 +++++++++++--------------
 security/pks/files/patch-kd_generic.c  |  4 ++--
 security/pks/files/patch-mkpksdconf.in |  4 ++--
 3 files changed, 15 insertions(+), 18 deletions(-)