Created attachment 250927 [details] sort out Makefile and pet portclippy v1 Suggested by diizzy https://reviews.freebsd.org/D45094#1028356: > x11/babl likely doesn't require libtool, you can probably drop localbase or or at least use localbase:ldflags Both removed. > SIMD option is only relevant on i386/amd64 (fix) and we can at least always rely on SSE2 on amd64 (requirement). Limit SIMD to i386/amd64, default for i386 is MMX only, for amd64 SSE2. But users can turn on or off all SIMD sets during build. > It would be nice(r) if we could rely on CPUTYPE from the framework Tested build in poudriere and on live system 13.3-p2 amd64 and i386 with different combinations of SIMDs and CPUTYPE in /etc/make.conf.
plist issues on arm64: Error: Missing: lib/babl-%%BABL_VER%%/arm-neon-CIE.so Error: Missing: lib/babl-%%BABL_VER%%/arm-neon-cairo.so Error: Missing: lib/babl-%%BABL_VER%%/arm-neon-double.so Error: Missing: lib/babl-%%BABL_VER%%/arm-neon-float.so Error: Missing: lib/babl-%%BABL_VER%%/arm-neon-gegl-fixups.so Error: Missing: lib/babl-%%BABL_VER%%/arm-neon-gggl-lies.so Error: Missing: lib/babl-%%BABL_VER%%/arm-neon-gggl.so Error: Missing: lib/babl-%%BABL_VER%%/arm-neon-grey.so Error: Missing: lib/babl-%%BABL_VER%%/arm-neon-simple.so Error: Missing: lib/babl-%%BABL_VER%%/arm-neon-u16.so Error: Missing: lib/babl-%%BABL_VER%%/arm-neon-u32.so Error: Missing: lib/babl-%%BABL_VER%%/arm-neon-ycbcr.so Test suite passes except for: 9/28 float-to-8bit FAIL 0.34s stdout: float -> u8 1 failed #1[1] got 76 expected 77 stderr: " 0x2dbc9de6f8b0 0x2dbc9de6d930 1" 70925056 BablFishPath cost:637.000000 error:0.000000000000 "/wrkdirs/usr/ports/x11/babl/work/babl-0.1.108/_build/extensions/gggl.so 0: R'G'B'A float to R'G'B'A u8" 0BablConversionLinear pixels:0 error: 0.000000
Created attachment 250932 [details] sort out Makefile and pet portclippy v2 1. Fixed plist for aarch64. 2. Removed MMX from default options for i386: base line is Pentium Pro - it doesn't have MMX.
(In reply to Robert Clausecker from comment #1) > 9/28 float-to-8bit FAIL 0.34s > stdout: > float -> u8 1 failed #1[1] got 76 expected 77 It's known issue: https://gitlab.gnome.org/GNOME/babl/-/issues/88
The updated patch tests fine on armv7. No more plist issues on arm64, though the test suite failure persists.
Waiting one more week for "maintainer timeout 2 weeks"…
LGTM
We should sort out aarch64 failure?
(In reply to Daniel Engberg from comment #7) It fixed in v2.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=bb1c7512f9d178ff5711bb2051006916482aa47a commit bb1c7512f9d178ff5711bb2051006916482aa47a Author: Vladimir Druzenko <vvd@FreeBSD.org> AuthorDate: 2024-06-01 20:20:01 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-06-01 23:16:56 +0000 x11/babl: sort out Makefile and pet portclippy Remove localbase. Limit SIMD to i386/amd64, default for i386 is none, for amd64 SSE2. But users can turn on or off all SIMD sets during build. PR: 279275 Approved by: fluffy (gnome, maintainer) x11/babl/Makefile | 45 +++++++++++++++++++++++++++++++++++---------- 1 file changed, 35 insertions(+), 10 deletions(-)