Bug 279358 - www/xcaddy: Seems like maybe lang/go should be a run dependency?
Summary: www/xcaddy: Seems like maybe lang/go should be a run dependency?
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-28 01:56 UTC by Robert William Vesterman
Modified: 2024-05-29 08:25 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert William Vesterman 2024-05-28 01:56:36 UTC 
I just installed www/xcaddy and tried running it:

# xcaddy
2024/05/27 21:51:39 [ERROR] exec [go list -mod=readonly -m -json all]: exec: "go": executable file not found in $PATH:
#

I don't have lang/go installed. Obviously I can (and momentarily will) install it, but it seems like www/xcaddy should have it as a runtime dependency so that it gets installed automatically? It looks like xcaddy has it marked as a build dependency, but not a runtime dependency.

Apologies if I'm misunderstanding something.
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-05-29 08:24:45 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=86bff3d95b03955a22d181fe064f81db968a1bb6

commit 86bff3d95b03955a22d181fe064f81db968a1bb6
Author:     Jimmy Olgeni <olgeni@FreeBSD.org>
AuthorDate: 2024-05-29 08:19:39 +0000
Commit:     Jimmy Olgeni <olgeni@FreeBSD.org>
CommitDate: 2024-05-29 08:23:58 +0000

    www/xcaddy: add missing RUN_DEPENDS on lang/go.

    xcaddy uses go to build custom releases of caddy, so it actually needs
    it at runtime.

    PR:             279358
    Reported by:    Robert William Vesterman <bob@vesterman.com>

 www/xcaddy/Makefile | 4 ++++
 1 file changed, 4 insertions(+)
Comment 2 Jimmy Olgeni freebsd_committer freebsd_triage 2024-05-29 08:25:27 UTC 
Yes that is correct, good catch - thanks!