Created attachment 251196 [details] pipe-viewer-0.5.1.patch Description: ChangeLog: https://github.com/trizen/pipe-viewer/blob/0.5.1/Changes * Recognize the new audio itag 774. * GUI: added "Backward" and "Forward" buttons for navigating the history. QA: * portlint: - WARN: Makefile: unless this is a master port, MAINTAINER has to be set by "=", not by "?=". - WARN: Makefile: unless this is a master port, COMMENT has to be set by "=", not by "?=". * testport: (poudriere: 14.0-RELEASE, amd64, FORK_MANAGER GTK3 JSON_XS LOCAL_CACHE READLINE SHARE_DIR LINE_BREAK YT_DLP tested): - Warning: devel/p5-Module-Build was in Perl CORE. Check with `corelist Module::Build 0.4206` and `corelist -a Module::Build` if it should be conditionally added depending on PERL_LEVEL - Notice: You have some Perl modules as dependencies but you do not have devel/p5-Module-CoreList installed, the perlcore QA check gets better results when using it, especially with older Perl versions.
====> Running Q/A tests (stage-qa) Warning: devel/p5-Module-Build was in Perl CORE. Check with `corelist Module::Build 0.4206` and `corelist -a Module::Build` if it should be conditionally added depending on PERL_LEVEL Notice: You have some Perl modules as dependencies but you do not have devel/p5-Module-CoreList installed, the perlcore QA check gets better results when using it, especially with older Perl versions. ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist ===> Checking for items in pkg-plist which are not in STAGEDIR Error: Missing: %%SITE_PERL%%/auto/share/dist/WWW-PipeViewer/icons/left_arrow.png Error: Missing: %%SITE_PERL%%/auto/share/dist/WWW-PipeViewer/icons/right_arrow.png ===> Error: Plist issues found. *** Error code 1 Can you fix those?
(In reply to Fernando Apesteguía from comment #1) That is very strange since those files were added to the pkg-plist of the patch.
(In reply to Jesús Daniel Colmenares Oviedo from comment #2) Have you tried this in poudriere?
Created attachment 251268 [details] pipe-viewer-0.5.1.patch Sorry, I only built gtk-pipe-viewer which installs those files, so poudriere doesn't show me any errors. I make a change to pkg-plist to conditionally add those files when building gtk-pipe-viewer and not pipe-viewer.
(In reply to Jesús Daniel Colmenares Oviedo from comment #4) I'll try that, thanks. > I only built gtk-pipe-viewer which installs those files, We should always try to build the port with the default options, since that is what will be done in the builders. Other option combinations are of course welcome :-) Cheers.
(In reply to Fernando Apesteguía from comment #5) Thank you, Fernando!
Committed, Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=780074f563f62d2dc4fb62150c5589ea58900565 commit 780074f563f62d2dc4fb62150c5589ea58900565 Author: Jesús Daniel Colmenares Oviedo <DtxdF@disroot.org> AuthorDate: 2024-06-07 13:02:57 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2024-06-07 17:56:37 +0000 multimedia/pipe-viewer: Update to 0.5.1 ChangeLog: https://github.com/trizen/pipe-viewer/blob/0.5.1/Changes * gui: added "Backward" and "Forward" buttons for navigating the history. PR: 279499 Reported by: DtxdF@disroot.org (maintainer) multimedia/pipe-viewer/Makefile | 2 +- multimedia/pipe-viewer/distinfo | 6 +++--- multimedia/pipe-viewer/pkg-plist | 2 ++ 3 files changed, 6 insertions(+), 4 deletions(-)